[Freeipa-devel] [PATCH 0391-0392] Add missing return value checks to pthread operations & replace strcmp(var, "") with strlen(var) to workaround Clang bug 20144

[Tomas Hozza]

On 03/01/2016 02:36 PM, Petr Spacek wrote:
> Hello,
>
> Add missing return value checks to pthread operations.
> Detected by clang 3.8 -O2 -Wunused-value.
>
> Replace strcmp(var, "") with strlen(var) to workaround Clang bug 20144.
> https://llvm.org/bugs/show_bug.cgi?id=20144
>

ACK.

I was not able to reproduce the issues. However the changes look good to me. I tested the plugin on Fedora 24 with basic tasks (query, zone transfer, DNS update) without DNSSEC signing.

Regards,
-- 
Tomas Hozza
Senior Software Engineer - EMEA ENG Developer Experience

PGP: 1D9F3C2D
UTC+1 (CET)
Red Hat Inc.                 http://cz.redhat.com