[Freeipa-devel] [PATCH 0096] Batch command: avoid accessing potentially undefined context.principa

Jan Cholasta jcholast at redhat.com
Thu May 12 11:29:17 UTC 2016


On 10.5.2016 12:34, Petr Spacek wrote:
> On 4.5.2016 15:04, Jan Cholasta wrote:
>> Hi,
>>
>> On 22.4.2016 13:28, Petr Spacek wrote:
>>> Hello,
>>>
>>> Batch command: avoid accessing potentially undefined context.principal
>>>
>>> This might happen when the command is called directly in Python,
>>> e.g. in installers and so on.
>>>
>>> Pylint pylint-1.5.5-1.fc24.noarch caught this.
>>>
>>> https://fedorahosted.org/freeipa/ticket/5838
>>
>> LGTM, but please use 'UNKNOWN' as the default value, for consistency with
>> ipalib.rpcserver code.
>
> Here you are.

Thanks, ACK.

Pushed to:
master: 89cdf6ee1e796e5ba4c302a19da4862e18b99c4a
ipa-4-2: da06be4ba891b1ad86af866fa4d9699bbaa5ab35
ipa-4-3: 2980e7851cba9bacefbc0adfab556634ec5fb6e6

-- 
Jan Cholasta




More information about the Freeipa-devel mailing list