[Freeipa-devel] [TESTS][PATCH] Ping module tests in a non-declarative way

[Peter Lacko]

Hi,

Thanks again, will remember that. I also changed header to short one.

Peter


----- Original Message -----
From: "Martin Basti" <mbasti at redhat.com>
To: "Peter Lacko" <placko at redhat.com>, freeipa-devel at redhat.com
Sent: Tuesday, May 10, 2016 12:23:13 PM
Subject: Re: [Freeipa-devel] [TESTS][PATCH] Ping module tests in a non-declarative way



On 28.04.2016 16:09, Martin Basti wrote:
>
>
> On 08.04.2016 10:32, Peter Lacko wrote:
>>
>>
>
> Hello,
>
> I have a few comments:
>
> 1)
> Please set up your git name and email correctly (consistently for all 
> patches)
> this is not right From: root<root at vm-058-184.abc.idm.lab.eng.brq.redhat.com>
>
> 2)
> -# Copyright (C) 2012  Red Hat
> +# Copyright (C) 2016  Red Hat
>
> leave there both years please
> +# Copyright (C) 2012, 2016  Red Hat
>
> 3)
> Please put the patch number to the email subject, it is easier to find correct patch for us
>
> Otherwise LGTM and works for me.
>
> Martin^2
>
>
Sorry I didn't noticed earlier, but your patch doesn't work under python3

     from xmlrpc_test import XMLRPC_test, raises_exact
E   ImportError: No module named 'xmlrpc_test'

You must use absolute import, not relative in py3

Martin^2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-placko-0001-3-Ping-module-tests.patch
Type: text/x-patch
Size: 3448 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160513/9916c253/attachment.bin>