[Freeipa-devel] [PATCH 0463] Performance: do not download password attributes in host/find-user command

[Rob Crittenden]

Martin Basti wrote:
>
>
> On 12.05.2016 19:48, Rob Crittenden wrote:
>> Martin Basti wrote:
>>>
>>>
>>> On 22.04.2016 13:21, David Kupka wrote:
>>>> On 22/04/16 10:58, Martin Basti wrote:
>>>>>
>>>>>
>>>>> On 21.04.2016 09:17, Martin Basti wrote:
>>>>>>
>>>>>>
>>>>>> On 20.04.2016 16:57, Martin Basti wrote:
>>>>>>> https://fedorahosted.org/freeipa/ticket/5281
>>>>>>>
>>>>>>> Patch attached.
>>>>>>>
>>>>>>>
>>>>>> selfNACK
>>>>>>
>>>>>>
>>>>> Updated patch attached.
>>>>>
>>>>>
>>>>>
>>>> Works for me, ACK.
>>>>
>>> pushed to master:
>>> * fe2ce02a6f7664e377c367e16e9c2e1ad960c9d7 Performace: don't download
>>> password attributes in host/user-find
>>>
>>
>> It occurs to me, won't this break the UI somewhat. Isn't Enrolled one
>> of the attributes on the default host page. Won't this show all hosts
>> as unenrolled?
>>
>> rob
>
> Hi Rob,
>
> how exactly is webUI broken? I tried host section and it works. IIUC the
> Web UI uses just host-find --pkey-only, which is not affected by this
> change. For additional details webUI call host-show for each listed entry

You're right, it was based on a bad assumption on my part. I assumed the 
UI took the output of host_find and displayed the results. Next time 
I'll check first.

rob