[Freeipa-devel] [PATCH 0099] ipa-nis-manage: add status option

[Petr Spacek]

On 20.5.2016 15:03, Martin Babinsky wrote:
> On 04/28/2016 05:15 PM, Petr Spacek wrote:
>> On 28.4.2016 14:52, Abhijeet Kasurde wrote:
>>> Hi Petr,
>>>
>>> On 04/25/2016 08:28 PM, Petr Spacek wrote:
>>>> Hello,
>>>>
>>>> ipa-nis-manage: add status option
>>>>
>>>> https://bugzilla.redhat.com/show_bug.cgi?id=1329275
>>>>
>>>>
>>>>
>>> Can you reword the error message here as well ?
>>>
>>>      if len(args) != 1:
>>>          sys.exit("You must specify one action, either enable or disable")
>>>
>>> Thanks,
>>> Abhijeet Kasurde
>>
>> Good catch!
>>
>>
>>
> 
> Hi Petr,
> 
> please use upstream ticket provided by Petr Vobornik[1] in the commit message.
> 
> Also I would rewrite
> 
> """+    elif args[0] != "enable" and args[0] != "disable" and args[0] !=
> "status":
> 
> """
> 
> in a more pythonic way:
> 
> "    elif args[0] not in {"enable", "disable", "status"}:"
> 
> Otherwise the patch works as expected.
> 
> [1] https://fedorahosted.org/freeipa/ticket/5856

Here you go.

-- 
Petr^2 Spacek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pspacek-0099-3-ipa-nis-manage-add-status-option.patch
Type: text/x-patch
Size: 3910 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160523/f63bfd59/attachment.bin>