[Freeipa-devel] [PATCH] 0002 Add the culprit line when a configuration file has an incorrect format

[Martin Basti]

On 27.05.2016 11:35, Florence Blanc-Renaud wrote:
>
> Hi all,
>
> this patch adds information to the output of ipa-client-install when 
> it fails due to invalid format in a configuration file:
> ipa-client-install failing with SyntaxError: Syntax Error: Unknown 
> line format
>
> Fixes: https://fedorahosted.org/freeipa/ticket/5811
>
> -- 
> Florence Blanc-Renaud
> Identity Management Team, Red Hat
>
>
Thank you for your patch, I have just one nitpick. Can you please reuse 
the original exception?

-            curopts.append(self.parseLine(line))
+            try:
+                curopts.append(self.parseLine(line))
+            except SyntaxError as e:
+                raise SyntaxError('{error} in file {fname}: 
[{line}]'.format(
+                    error=e, fname=f.name, line=line))

Martin^2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160530/cf08c77d/attachment.htm>