[Freeipa-devel] [PATCH 0033] Fix CA being presented as running even if it weren't

Stanislav Laznicka slaznick at redhat.com
Tue May 31 09:40:05 UTC 2016


On 05/31/2016 10:22 AM, Stanislav Laznicka wrote:
> On 05/30/2016 12:54 PM, Jan Cholasta wrote:
>> On 30.5.2016 12:36, Martin Basti wrote:
>>>
>>>
>>> On 26.05.2016 19:31, Stanislav Laznicka wrote:
>>>>
>>>> Self NACK. I should not post patches when tired, sorry. Minor fix is
>>>> attached.
>>>>
>>>>
>>>> On 05/26/2016 07:21 PM, Stanislav Laznicka wrote:
>>>>> Hello,
>>>>>
>>>>> Please, see the attached patch. Fixes
>>>>> https://fedorahosted.org/freeipa/ticket/5898
>>>>>
>>>>> Standa
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>
>>> LGTM, if nobody is against this, I will push it in 2 days
>>
>> NACK, please add `wait` argument and call self.wait_until_running(), 
>> same as in start() and restart().
>>
> A pretty good point, please see the modified patch.
>
>
Self.NACK - can't add 'wait' agrument to service.Service.is_running this 
easy.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20160531/2426667e/attachment.htm>


More information about the Freeipa-devel mailing list