[Freeipa-devel] [freeipa PR#142][comment] CheckedIPAddress: Implement __(g|s)etstate__ and to ensure proper (un)pickling
mbasti-rh
freeipa-github-notification at redhat.com
Thu Oct 6 12:40:35 UTC 2016
URL: https://github.com/freeipa/freeipa/pull/142
Title: #142: CheckedIPAddress: Implement __(g|s)etstate__ and to ensure proper (un)pickling
mbasti-rh commented:
"""
IMO here (__init__ of CheckedIPAddress) is missing self._net = addr._net it may cause issues
```
if isinstance(addr, CheckedIPAddress):
self.prefixlen = addr.prefixlen
return
```
and self._net should be handled in parent class
"""
See the full comment at https://github.com/freeipa/freeipa/pull/142#issuecomment-251949631
More information about the Freeipa-devel
mailing list