[Freeipa-devel] [freeipa PR#52] Removed incorrect check for returncode (comment)

mbasti-rh freeipa-github-notification at redhat.com
Mon Sep 5 08:32:58 UTC 2016


mbasti-rh commented on a pull request

"""
ACK: Removed incorrect check for returncode
NACK:  Several fixes in replica_promotion tests -- missing explanation in commit messages why this change is needed, if changes are unrelated should be in multiple patches 
ACK: Changed addressing to the client hosts to be replicas
ACK: Xfailed the tests due to a known bug with replica preparation
"""

See the full comment at https://github.com/freeipa/freeipa/pull/52#issuecomment-244689293


More information about the Freeipa-devel mailing list