[Freeipa-devel] [PATCH 0183] ipa-advise: correct handling of plugin namespace iteration

Jan Cholasta jcholast at redhat.com
Wed Sep 7 13:57:56 UTC 2016


On 19.7.2016 09:15, Martin Babinsky wrote:
> On 07/18/2016 08:46 AM, Jan Cholasta wrote:
>> Hi,
>>
>> On 11.7.2016 14:18, Martin Babinsky wrote:
>>> https://fedorahosted.org/freeipa/ticket/6044
>>
>> Note that you should use .name rather than .__name__ to get plugin
>> names, otherwise the code won't work with plugins with non-default names.
>>
>> There currently aren't any Advice plugins with non-default name, but I
>> would rather fix this now to avoid surprises later.
>>
>> Honza
>>
>
> I didn't realize this when doing the patch, here's the fix for that.
>
> I have attached the original closed ticket to the commit message, should
> I create a new ticket for such a small change?

Bump. I'm fine with new ticket or no ticket, but don't use 6044.

-- 
Jan Cholasta




More information about the Freeipa-devel mailing list