[Freeipa-devel] [freeipa PR#68] netgroup: avoid extraneous LDAP search when retrieving primary key from DN (comment)

stlaz freeipa-github-notification at redhat.com
Fri Sep 9 10:37:47 UTC 2016


stlaz commented on a pull request

"""
Please add ```assert isinstance(dn, DN)``` as in the parent method.

Also, I think maybe it's safer to check for rdns emptiness before you try to assign from it.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/68#issuecomment-245878203


More information about the Freeipa-devel mailing list