[Freeipa-devel] [freeipa PR#713][opened] WebUI: fix showing required asterisk '*'

pvomacka freeipa-github-notification at redhat.com
Thu Apr 13 15:27:17 UTC 2017


   URL: https://github.com/freeipa/freeipa/pull/713
Author: pvomacka
 Title: #713: WebUI: fix showing required asterisk '*'
Action: opened

PR body:
"""
There was a bug that when user switch between two facets where is
required field and in one of them is writable and in second one
is not writable, then the asterisk which marks required field is
not shown. i.e. admin vs. user details page or global_passwd_policy
vs. other_passwd_policy details page.

That was caused by incorrect evaluation of required state of field.
Evaluation works that way: evaluate old required state, then evaluate
current required state and if states has changed then emit change event.
The evaluation depends on writable and read_only state of field.
Those two states are set before evaluation of required state, but
their old values (for evaluating previous required stated) were
not stored anywhere.

This commit adds two attributes which stores old writable
and read_only states. The required asterisk is then shown correctly.

https://pagure.io/freeipa/issue/6849
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/713/head:pr713
git checkout pr713
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pr-713.patch
Type: text/x-diff
Size: 4264 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20170413/b8ea210e/attachment.bin>


More information about the Freeipa-devel mailing list