[Freeipa-devel] [freeipa PR#434][comment] csrgen: Automate full cert request flow

MartinBasti freeipa-github-notification at redhat.com
Tue Feb 7 17:59:28 UTC 2017


  URL: https://github.com/freeipa/freeipa/pull/434
Title: #434: csrgen: Automate full cert request flow

MartinBasti commented:
"""
- pylint:
```
************* Module ipaclient.plugins.cert
ipaclient/plugins/cert.py:102: [W1612(unicode-builtin), cert_request.forward] unicode built-in referenced)
ipaclient/plugins/cert.py:127: [W1612(unicode-builtin), cert_request.forward] unicode built-in referenced)
ipaclient/plugins/cert.py:99: [W0612(unused-variable), cert_request.forward] Unused variable 'requestdata')
```

for unicode you can use etiher `six.string_type()` or
```
if six.PY3:
    unicode = str
```

-  pep8 errors
- failing test expects DN object instead of String
"""

See the full comment at https://github.com/freeipa/freeipa/pull/434#issuecomment-278085296


More information about the Freeipa-devel mailing list