[Freeipa-devel] [freeipa PR#492][opened] [WIP] config: remove meaningless defaults

HonzaCholasta freeipa-github-notification at redhat.com
Tue Feb 21 14:30:55 UTC 2017


   URL: https://github.com/freeipa/freeipa/pull/492
Author: HonzaCholasta
 Title: #492: [WIP] config: remove meaningless defaults
Action: opened

PR body:
"""
**ipalib.constants: Remove default domain, realm, basedn, xmlrpc_uri, ldap_uri**

Domain, realm, basedn, xmlrpc_uri, ldap_uri do not have any reasonable default.
This patch removes hardcoded default so the so the code which depends
on these values blows up early and does not do crazy stuff
with default values instead of real ones.

This should help to uncover issues caused by improper ipalib
initialization.

**config: provide defaults for `xmlrpc_uri`, `ldap_uri` and `basedn`**

Derive the default value of `xmlrpc_uri` and `ldap_uri` from `server`.
Derive the default value of `basedn` from `domain`.

This supersedes @pspacek's PR #113.
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/492/head:pr492
git checkout pr492
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pr-492.patch
Type: text/x-diff
Size: 7201 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20170221/4231ffe0/attachment.bin>


More information about the Freeipa-devel mailing list