[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

lslebodn freeipa-github-notification at redhat.com
Wed Feb 22 10:33:14 UTC 2017


  URL: https://github.com/freeipa/freeipa/pull/494
Title: #494: Support client-only build

lslebodn commented:
"""
On (22/02/17 02:23), Christian Heimes wrote:
>tiran requested changes on this pull request.
>
>see comments
>
>> -CFLAGS="$bck_cflags"
>-
>-LIBPDB_NAME=""
>-AC_CHECK_LIB([samba-passdb],
>-             [make_pdb_method],
>-             [LIBPDB_NAME="samba-passdb"; HAVE_LIBPDB=1],
>-             [LIBPDB_NAME="pdb"],
>-             [$SAMBA40EXTRA_LIBPATH])
>-
>-if test "x$LIB_PDB_NAME" = "xpdb" ; then
>-  AC_CHECK_LIB([$LIBPDB_NAME],
>-               [make_pdb_method],
>-               [HAVE_LIBPDB=1],
>-               [AC_MSG_ERROR([Neither libpdb nor libsamba-passdb does have make_pdb_method])],
>-               [$SAMBA40EXTRA_LIBPATH])
>+AC_MSG_CHECKING($(basename $PYTHON) module setuptools )
>
>Please put this in a separate PR. This is not related to --disable-server.
>

refactoring/cleaning is requred for minimising dependencies before split.
Otherwise git log would be confusing.


>+AM_CONDITIONAL([ENABLE_SERVER], [test x"$enable_server" = xyes])
>+if test x"$enable_server" = xyes; then
>+    m4_include([server.m4])
>+fi
>+
>+AC_ARG_WITH([tests],
>+    [AC_HELP_STRING([--with-tests],
>
>NACK, ```without-ipatests```
>
already changed.

LS

"""

See the full comment at https://github.com/freeipa/freeipa/pull/494#issuecomment-281631097


More information about the Freeipa-devel mailing list