[Freeipa-devel] [freeipa PR#492][comment] [WIP] config: remove meaningless defaults

tiran freeipa-github-notification at redhat.com
Wed Feb 22 18:37:32 UTC 2017


  URL: https://github.com/freeipa/freeipa/pull/492
Title: #492: [WIP] config: remove meaningless defaults

tiran commented:
"""
It's probably easier to always define options like ```'ldap_uri``` but use ```None``` as default.

```
cd .; ./makeaci --validate
./makeaci: ipaserver/plugins/dogtag.py:244: ignoring ImportError: No module named backports_abc
./makeaci: ipaserver/plugins/dogtag.py:244: ignoring ImportError: No module named rnc2rng
Traceback (most recent call last):
  File "./makeaci", line 134, in <module>
    main(options)
  File "./makeaci", line 107, in main
    api.finalize()
  File "/freeipa/ipalib/plugable.py", line 747, in finalize
    self._get(plugin)
  File "/freeipa/ipalib/plugable.py", line 776, in _get
    instance = self.__instances[plugin] = plugin(self)
  File "/freeipa/ipaserver/plugins/ldap2.py", line 72, in __init__
    ldap_uri = api.env.ldap_uri
AttributeError: 'Env' object has no attribute 'ldap_uri'
Exception AttributeError: "'ldap2' object has no attribute
'id'" in <bound method ldap2.__del__ of ipaserver.plugins.ldap2.ldap2()> ignored
make: *** [acilint] Error 1
Makefile:1108: recipe for target 'acilint' failed
```
"""

See the full comment at https://github.com/freeipa/freeipa/pull/492#issuecomment-281760358


More information about the Freeipa-devel mailing list