[Freeipa-devel] [freeipa PR#501][opened] C compilation fixes and hardening

tiran freeipa-github-notification at redhat.com
Fri Feb 24 07:25:10 UTC 2017


   URL: https://github.com/freeipa/freeipa/pull/501
Author: tiran
 Title: #501: C compilation fixes and hardening
Action: opened

PR body:
"""
Fix "implicit declaration of function ‘strlen’" in ipa_pwd_ntlm.c,
credits to Lukas.

Add -Werror=implicit-function-declaration to CFLAGS to point developers
to missing includes. It causes compilation to fail when a developer
forgets to add a required include. The problem is no longer hidden in a
massive wall of text from make.

Silence a harmless error from 389-DS slapi.h until the bug is fixed in
downstream, https://pagure.io/389-ds-base/issue/48979

Signed-off-by: Christian Heimes <cheimes at redhat.com>
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/501/head:pr501
git checkout pr501
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pr-501.patch
Type: text/x-diff
Size: 1539 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20170224/59ae25f9/attachment.bin>


More information about the Freeipa-devel mailing list