[Freeipa-devel] [freeipa PR#475][comment] Add options to run only ipaclient unittests
martbab
freeipa-github-notification at redhat.com
Tue Feb 28 15:37:42 UTC 2017
URL: https://github.com/freeipa/freeipa/pull/475
Title: #475: Add options to run only ipaclient unittests
martbab commented:
"""
I am not a big fan of mixing filename matching and markers in this PR. I feel that using only one of those approaches is a more cleaner solution and it seems that marking all the tests and then running a subset using the pytest's marker selection API loks like the easiest road.
It seems like a daunting task but it may actually be easier given that you can mark whole modules[1] or even generate marker dynamically by introspecting node IDs during test collection[2].
You can ultimately provide an option as an alias for selecting/deselecting markers as needed if you like but the underlying implementation will be cleaner as result.
[1] http://doc.pytest.org/en/latest/example/markers.html#marking-whole-classes-or-modules
[2] http://doc.pytest.org/en/latest/example/markers.html#automatically-adding-markers-based-on-test-names
"""
See the full comment at https://github.com/freeipa/freeipa/pull/475#issuecomment-283073142
More information about the Freeipa-devel
mailing list