[Freeipa-devel] [freeipa PR#373][comment] ipaplatform: Add Debian platform module.

tiran freeipa-github-notification at redhat.com
Wed Jan 11 10:40:58 UTC 2017


  URL: https://github.com/freeipa/freeipa/pull/373
Title: #373: ipaplatform: Add Debian platform module.

tiran commented:
"""
pylint is failing:
```
Pylint is running, please wait ...
************* Module ipaplatform.debian.tasks
ipaplatform/debian/tasks.py:10: [E0611(no-name-in-module), ] No name 'BaseTaskNameSpace' in module 'ipaplatform.base.tasks')
ipaplatform/debian/tasks.py:49: [E0602(undefined-variable), DebianTaskNamespace.parse_ipa_version] Undefined variable 'BaseTaskNamespace')
ipaplatform/debian/tasks.py:9: [W0611(unused-import), ] Unused paths imported from ipaplatform.paths)
ipaplatform/debian/tasks.py:10: [W0611(unused-import), ] Unused BaseTaskNameSpace imported from ipaplatform.base.tasks)
************* Module ipaplatform.debian.services
ipaplatform/debian/services.py:64: [R0102(simplifiable-if-statement), DebianSysvService.stop] The if statement can be replaced with 'var = bool(test)')
ipaplatform/debian/services.py:65: [W0612(unused-variable), DebianSysvService.stop] Unused variable 'update_service_list')
ipaplatform/debian/services.py:73: [R0102(simplifiable-if-statement), DebianSysvService.start] The if statement can be replaced with 'var = bool(test)')
ipaplatform/debian/services.py:74: [W0612(unused-variable), DebianSysvService.start] Unused variable 'update_service_list')
ipaplatform/debian/services.py:9: [W0611(unused-import), ] Unused import time)
ipaplatform/debian/services.py:11: [W0611(unused-import), ] Unused tasks imported from ipaplatform.tasks)
ipaplatform/debian/services.py:15: [W0611(unused-import), ] Unused root_logger imported from ipapython.ipa_log_manager)
make: *** [pylint] Error 14
```
"""

See the full comment at https://github.com/freeipa/freeipa/pull/373#issuecomment-271836117


More information about the Freeipa-devel mailing list