[Freeipa-devel] [freeipa PR#501][comment] C compilation fixes and hardening

lslebodn freeipa-github-notification at redhat.com
Wed Mar 1 09:57:53 UTC 2017


  URL: https://github.com/freeipa/freeipa/pull/501
Title: #501: C compilation fixes and hardening

lslebodn commented:
"""
FYI; it is far far away from best practice to modify `CFLAGS` and configure time; unless you test compiler options. Such change should be in makefile `AM_CFLAGS`

In the future, try to address comments in PR  (#364) rather then ignoring them and then fixing in new PR

"""

See the full comment at https://github.com/freeipa/freeipa/pull/501#issuecomment-283296048


More information about the Freeipa-devel mailing list