[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

lslebodn freeipa-github-notification at redhat.com
Wed Mar 1 10:07:55 UTC 2017


  URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional

lslebodn commented:
"""
Writing hint together with error is the simplest solution. And still remind developers to install pylint/jslint.

e.g.
```
diff --git a/configure.ac b/configure.ac
index af41f5e3a..c02dd1fe4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -384,7 +384,10 @@ if test x$PYLINT != xno; then
     AC_MSG_CHECKING([for Pylint])
     $PYTHON -m pylint --version > /dev/null
     if test "$?" != "0"; then
-        AC_MSG_ERROR([cannot find pylint for $PYTHON])
+        AC_MSG_ERROR([cannot find pylint for $PYTHON
+This feature is optional and aimed for developers. You can skip this check
+wich configure time option --disable-pylint
+        ])
     else
         AC_MSG_RESULT([yes])
     fi

```

"""

See the full comment at https://github.com/freeipa/freeipa/pull/502#issuecomment-283298387


More information about the Freeipa-devel mailing list