[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

lslebodn freeipa-github-notification at redhat.com
Wed Mar 1 13:08:26 UTC 2017


  URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional

lslebodn commented:
"""
It was explained on IRC
> < cheimes> lslebodn: Your proposal is missing the point of the ticket. It doesn't not simplify
>                 building, but rather improves error messages. The whole point of the ticket is a more
>                 pleasant experience for outsiders that are not FreeIPA core contributors.

But there is main problem with this PR. The design document expected these option enabled by default.
http://www.freeipa.org/page/V4/Build_system_refactoring

This is a reason why I mentioned to log just a hint for optional *lint dependencies.

And ticket https://pagure.io/freeipa/issue/6604 says that options were made optional a moth ago

master:

*    5c18feaa206bbaee692fc3640b7b79c8d9d6a638 CONFIGURE: Fix detection of pylint
*    3f91469f327d8d9f3b27e0b67c54a4f47ad845c1 CONFIGURE: Update help message for jslint
*    b82d285a4a75e11cc9291ecca12d2fcc26f43ed1 SPEC: Fix build in mock
"""

See the full comment at https://github.com/freeipa/freeipa/pull/502#issuecomment-283335089


More information about the Freeipa-devel mailing list