[Freeipa-devel] [freeipa PR#502][comment] Make pylint and jsl optional

HonzaCholasta freeipa-github-notification at redhat.com
Thu Mar 2 06:37:43 UTC 2017


  URL: https://github.com/freeipa/freeipa/pull/502
Title: #502: Make pylint and jsl optional

HonzaCholasta commented:
"""
I tend to agree with @lslebodn, but I don't have a strong opinion on this. I noticed a couple of issues though:

* `--without-jslint` does not seem to work correctly:
  ```
  $ ./configure --without-jslint
  ...
                      IPA Server 4.4.90.dev201703020634+git3a29b47
                      ========================
  ...
          jslint:                   /usr/bin/jsl
  ...
  ```

* In `freeipa.spec.in`, when `with_lint` is not defined, lint should be disabled, so `--disable-pylint` and `--without-jslint` should be passed to `%configure`.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/502#issuecomment-283569745


More information about the Freeipa-devel mailing list