[Freeipa-devel] [freeipa PR#537][opened] test_csrgen: adjusted comparison test scripts for CSRGenerator

Rezney freeipa-github-notification at redhat.com
Fri Mar 3 10:42:44 UTC 2017


   URL: https://github.com/freeipa/freeipa/pull/537
Author: Rezney
 Title: #537: test_csrgen: adjusted comparison test scripts for CSRGenerator
Action: opened

PR body:
"""
Commit ada91c2 introduced changes in "csrgen/templates/openssl_base.tmpl"
which broke the following 2 tests:

    test_CSRGenerator.test_userCert_OpenSSL
    test_CSRGenerator.test_caIPAserviceCert_OpenSSL

The tests use files caIPAserviceCert_openssl.sh and userCert_openssl.sh
as expected scripts in order to compare scripts generated by CSRGenerator.
E.g. as other parameter was introduced we are now not checking with
"if [[ $# -ne 2 ]]" but rather with if "[[ $# -lt 2 ]]".

https://pagure.io/freeipa/issue/6724
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/537/head:pr537
git checkout pr537
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pr-537.patch
Type: text/x-diff
Size: 2777 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20170303/ad00adfe/attachment.bin>


More information about the Freeipa-devel mailing list