[Freeipa-devel] [freeipa PR#593][opened] WIP: Add make patchcheck for developers

tiran freeipa-github-notification at redhat.com
Wed Mar 15 07:41:57 UTC 2017


   URL: https://github.com/freeipa/freeipa/pull/593
Author: tiran
 Title: #593: WIP: Add make patchcheck for developers 
Action: opened

PR body:
"""
Ticket 6604 makes pylint and jsl optional dependencies. The change
is controversal, because some developers prefer that pylint and jsl
should be required unless explicitly disabled.

`make patchcheck` is my answer to address the concerns. It's a superior
solution to `make lint` as pre-commit check. It combines several
additional checks under a single, easy rememberable and convenient make
target:

* build all
* acilint, apiclient, jslint, polint
* make check
* pylint under Python 2 and 3
* subset of unit test suite

https://fedorahosted.org/freeipa/ticket/6604
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/593/head:pr593
git checkout pr593
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pr-593.patch
Type: text/x-diff
Size: 16345 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20170315/4ff2b208/attachment.bin>


More information about the Freeipa-devel mailing list