[Freeipa-devel] [freeipa PR#590][comment] Validate user input for cert-get-requestdata

rcritten freeipa-github-notification at redhat.com
Wed Mar 15 13:28:01 UTC 2017


  URL: https://github.com/freeipa/freeipa/pull/590
Title: #590: Validate user input for cert-get-requestdata

rcritten commented:
"""
You are duplicating the list of helpers. It would have been better to have helper defined as a StrEnum. If it isn't too late to change (e.g. no release has shipped with that in the API) then perhaps a separate patch, then you wouldn't need this enforcement at all.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/590#issuecomment-286740595


More information about the Freeipa-devel mailing list