[Freeipa-devel] [freeipa PR#616][comment] Simplify KRA transport cert cache
HonzaCholasta
freeipa-github-notification at redhat.com
Mon Mar 20 06:20:50 UTC 2017
URL: https://github.com/freeipa/freeipa/pull/616
Title: #616: Simplify KRA transport cert cache
HonzaCholasta commented:
"""
@tiran,
* patches targeted at backport branches should be as small as possible,
* it's hard to see what is an actual change and what is just a formatting / naming change,
* the formatting changes do not add any value, the code is already PEP8 compliant,
* using a mapping interface is KISS too.
I don't think this needs to be discussed further, either do the requested changes or this PR won't be merged.
"""
See the full comment at https://github.com/freeipa/freeipa/pull/616#issuecomment-287685144
More information about the Freeipa-devel
mailing list