[Freeipa-devel] [bind-dyndb-ldap PR#11][comment] Coverity: fix REVERSE_INULL for pevent->inst

pemensik bind-dyndb-ldap-github-notification at redhat.com
Thu Mar 30 12:40:08 UTC 2017


  URL: https://github.com/freeipa/bind-dyndb-ldap/pull/11
Title: #11: Coverity: fix REVERSE_INULL for pevent->inst

pemensik commented:
"""
Hi Tomáš,

I did not find any place which could result with inst == NULL. ldap_sync_prepare contains proper REQUIRE(inst != null) and all other function uses its result stored in ls_private. I think null check does not harm anything. It is used in BIND to catch unexpected problems after code changes. I would suggest to place one require at the beginning of syncrepl_update function also.

Overall I think it should be merged.
"""

See the full comment at https://github.com/freeipa/bind-dyndb-ldap/pull/11#issuecomment-290398226


More information about the Freeipa-devel mailing list