[Freeipa-devel] [freeipa PR#761][comment] Fixing adding authenticator indicators to host

pvoborni freeipa-github-notification at redhat.com
Thu May 4 12:35:09 UTC 2017


  URL: https://github.com/freeipa/freeipa/pull/761
Title: #761: Fixing adding authenticator indicators to host

pvoborni commented:
"""
I'd fix it on all places in host-mod:
```
  885                  raise errors.ACIError(info=msg)
  886              obj_classes = entry_attrs_old['objectclass']
  887:             if 'krbprincipalaux' not in obj_classes:
  888                  obj_classes.append('krbprincipalaux')
  889                  entry_attrs['objectclass'] = obj_classes
  ...
  921                  _entry_attrs = ldap.get_entry(dn, ['objectclass'])
  922                  obj_classes = _entry_attrs['objectclass']
  923:             if 'ieee802device' not in obj_classes:
  924                  obj_classes.append('ieee802device')
  925                  entry_attrs['objectclass'] = obj_classes
  ...
  941                  _entry_attrs = ldap.get_entry(dn, ['objectclass'])
  942                  obj_classes = entry_attrs['objectclass'] = _entry_attrs['objectclass']
  943:             if 'ipasshhost' not in obj_classes:
  944                  obj_classes.append('ipasshhost')
```

so that the plugin would be consistent. Rest of framework can be fixed other time.
"""

See the full comment at https://github.com/freeipa/freeipa/pull/761#issuecomment-299172235


More information about the Freeipa-devel mailing list