<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html; charset=UTF-8" http-equiv="Content-Type"> </head> <body bgcolor="#ffffff" text="#000000"> On 09/28/2010 07:20 PM, Endi Sukma Dewata wrote: <blockquote cite="mid:253753478.617471285716011765.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com" type="cite"> <pre wrap="">Hi, Please review the attached patch. It can be tested by moving one of the JSON files in test/data somewhere else. Thanks! The ipa_cmd() has been modified such that when an error occurs a dialog box will appear showing the error message with 2 buttons: Retry and Cancel. If Retry is clicked, it will attempt to execute the same operation again. If Cancel is clicked, the operation will be canceled and the control is returned to the caller. The associate.js, details.js, entity.js, search.js, and webui.js have been modified to display the error message inside the page. This behavior can be changed in the future (e.g. redirect to error page). The navigation.js and webui.js have been modified to render only the visible tabs. This improves the performance and reduce hidden errors. Some variables/functions also have been renamed for consistency. -- Endi S. Dewata </pre> <pre wrap=""> <fieldset class="mimeAttachmentHeader"></fieldset> _______________________________________________ Freeipa-devel mailing list <a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a> <a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre> </blockquote> Endi, can you add in a Unit test for this? If need be, extend the ipa_cmd so that it looks for an optional command line param that makes it try to fetch a .json file that doesn't exist: Something like var suffix = $.bbq.get("cmd_suffix"); if (suffix){ method += suffix; } method += '.json'; ... </body> </html>