<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 09/30/2010 09:20 AM, Adam Young wrote:
<blockquote cite="mid:4CA48EA4.5050504@redhat.com" type="cite">On
09/30/2010 09:18 AM, Adam Young wrote:
<br>
<blockquote type="cite">On 09/29/2010 11:07 PM, Endi Sukma Dewata
wrote:
<br>
<blockquote type="cite">----- "Adam
Young"<a class="moz-txt-link-rfc2396E" href="mailto:ayoung@redhat.com"><ayoung@redhat.com></a> wrote:
<br>
<br>
<blockquote type="cite">Should have remembered this approach,
standard JS way to deal with
<br>
undefined values.
<br>
</blockquote>
admiyo-freeipa-0048-3-Item-Level-Undo.patch
<br>
<br>
A few notes:
<br>
<br>
1. You're replying to the wrong thread :)
<br>
</blockquote>
<br>
Fixed :)
<br>
<br>
<blockquote type="cite">2. The undo button will only appear when
the input field loses focus. Ideally
<br>
it should appear as soon as the value is changed, but I'm not sure if
it's
<br>
possible to do that in JS. This can be addressed in the future.
<br>
</blockquote>
<br>
Right. I was scared off by the docs that claimedthings were so
different between browsers for the keydown and keypress events, but it
looks like whatever differences there are are irrelevant here. Change
to triggering on keydown.
<br>
<br>
<blockquote type="cite">3. The hint_span doesn't seem to be used
consistently in details.js:272-297:
<br>
<br>
ipa_insert_first_dd(
<br>
jobj, ipa_create_input(obj_name, attr, value[0],hint_span)
<br>
);
<br>
ipa_insert_other_dd(
<br>
jobj, ipa_create_input(obj_name, attr, value[i],hint_span)
<br>
);
<br>
ipa_insert_other_dd(
<br>
jobj.next(), _ipa_a_add_template.replace('A', attr)
<br>
);
<br>
ipa_insert_first_dd(
<br>
jobj, _ipa_a_add_template.replace('A', attr) /*.append(
hint_span)*/
<br>
);
<br>
ipa_insert_first_dd(
<br>
jobj, ipa_create_input(obj_name, attr, '')/*.append( hint_span)*/
<br>
);
<br>
</blockquote>
<br>
Yeah, but that mirrors the original code. I think figuring out where
to put the hintspan and how to trigger it is a different patch.
Hintspan should probably not be duplicated like this at all.
<br>
<br>
<blockquote type="cite">4. I think the statement on line 341 should
be removed because it redefines
<br>
the input variable:
<br>
<br>
var input = $("<label>",{html:value.toString()});
<br>
<br>
5. There is a trailing whitespace on line 337.
<br>
</blockquote>
Why, so there is....was.
<br>
<blockquote type="cite">Thanks!
<br>
<br>
-- <br>
Endi S. Dewata
<br>
</blockquote>
<br>
_______________________________________________
<br>
Freeipa-devel mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<br>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a>
<br>
</blockquote>
<br>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
ACKed in IRC, pushed to master<br>
</body>
</html>