<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#ffffff" text="#000000"> On 10/19/2010 03:12 PM, Endi Sukma Dewata wrote: <blockquote cite="mid:4CBDED80.8010802@redhat.com" type="cite">Hi, Please review the attached patch. Thanks! <a class="moz-txt-link-freetext" href="https://fedorahosted.org/reviewboard/r/94/">https://fedorahosted.org/reviewboard/r/94/</a> The service certificate management UI has been generalized and moved into certificate.js. The host details page is now using the same code to manage certificates. The host.py has been modified to return host certificate info. The Get/Revoke/View buttons behavior has been modified such that they are visible only if there is a valid certificate. The Get dialog box has been fixed to show the correct certificate header and footer. New unit tests for certificate has been added. The test data has been modified to include sample host certificate. <pre wrap=""> <fieldset class="mimeAttachmentHeader"></fieldset> _______________________________________________ Freeipa-devel mailing list <a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a> <a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre> </blockquote> For the most part looks ok. I don't like the appraoch to validating preconditions where we raise an alert for each. Also, make sure you don't code styles like color right into the Javascript, that stuff belonds in ipa.css. With those changes, ACK </body> </html>