<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 12/02/2010 10:19 AM, Adam Young wrote:
<blockquote cite="mid:4CF7B913.5060403@redhat.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
On 12/01/2010 08:56 PM, Endi Sukma Dewata wrote:
<blockquote cite="mid:4CF6FCCD.905@redhat.com" type="cite">Hi, <br>
<br>
Please review the attached patch. Thanks! <br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://fedorahosted.org/reviewboard/r/112/">https://fedorahosted.org/reviewboard/r/112/</a>
<br>
<br>
The enrollment dialog has been modified to use scrollable tables that <br>
supports multiple columns to display the search results and selected <br>
entries. The columns are specified by calling create_adder_column() <br>
on the association facet. By default the tables will use only one <br>
column which is to display the primary keys. <br>
<br>
The following enrollment dialogs have been modified to use multiple <br>
columns: <br>
- Group's member_user <br>
- Service's managedby_host <br>
- HBAC Service Group's member_hbacsvc <br>
- SUDO Command Group's member_sudocmd <br>
<br>
The ipa_association_table_widget's add() and remove() have been moved <br>
into ipa_association_facet so they can be customized by facet's <br>
subclass. The ipa_table's add_row() has been renamed to add_record(). <br>
<br>
Some old code has been removed from ipa_facet_create_action_panel(). <br>
The code was used to generate association links from a single facet. <br>
It's no longer needed because now each association has its own facet. <br>
<br>
The test data has been updated. The IPA.nested_tabs() has been fixed <br>
to return the entity itself if IPA.tab_set is not defined. This is <br>
needed to pass unit test. <br>
<br>
<pre wrap=""><fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Freeipa-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated"
href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
<br>
Looks good. Some nits.<br>
<br>
Move the "width: 200px" into the style sheet. We should have a css
class that is used for all of the checkbox columns.<br>
<br>
Why are the is create_adder_column on the association facet and not the
adder object? Shouldn't it be adder.add_column?<br>
Remove the parentesis in these and just ue the plural. var
header_message = that.other_entity + '(s) enrolled in ' +
that.entity_name + ' ' + that.pkey;<br>
<br>
That string actually needs to come from the association definition. I
realize that these are autogenerated, but the generic word "enrolled"
doesn't work for the majority of the associations. For instance, user
should say: "groups containing user kfrog". You can use the plural
name of the object out of the meta data for the other entity:
IPA.metadata[entity].object_name_plural.<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
ACK. Pushed to master<br>
</body>
</html>