<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#ffffff" text="#000000"> On 01/12/2011 10:07 PM, Endi Sukma Dewata wrote: <blockquote cite="mid:4D2E6C5D.2050004@redhat.com" type="cite">On 1/13/2011 9:11 AM, Endi Sukma Dewata wrote: <blockquote type="cite">The attached patch should address issue #1 and #2 in this bug: <a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/670">https://fedorahosted.org/freeipa/ticket/670</a> The labels for the following fields in Host details page have been changed: - fqdn: Fully Qualified Host Name - serverhostname: Host Name The ipa_details_field_create_input() and _ipa_create_text_input() has been converted into methods in ipa_details_field class. The code has been modified to display read-only fields as labels instead of disabled text fields. </blockquote> Rebased against the latest. <pre wrap=""> <fieldset class="mimeAttachmentHeader"></fieldset> _______________________________________________ Freeipa-devel mailing list <a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a> <a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre> </blockquote> can you replace the huge if-else block in details.js line 282? You cna leave the comment about class-specific implementation, but the code does nothing of use as is. Other than that, ACK. </body> </html>