<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html; charset=UTF-8" http-equiv="Content-Type"> <title></title> </head> <body bgcolor="#ffffff" text="#000000"> On 02/15/2011 08:25 AM, Martin Kosek wrote: <blockquote cite="mid:1297776332.3047.3.camel@dhcp-25-52.brq.redhat.com" type="cite"> <pre wrap="">Many WebUI identifiers were defined in a global namespace. This is not a good programming practice and may result in name clashes, for example with other libraries. This patch moves these variables to IPA namespace or its sub-namespaces, if required. <a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/212">https://fedorahosted.org/freeipa/ticket/212</a> </pre> <pre wrap=""> <fieldset class="mimeAttachmentHeader"></fieldset> _______________________________________________ Freeipa-devel mailing list <a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a> <a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre> </blockquote> Nice work. One thing I think we should make heppen before we push this is to scope down the number of IPA.functions. For example, the certificate widget should be the only thing that needs to access most of the functions in certificate.js. We can avoid making them publicly accessible. The certificate_status_widget should probably be directly under IPA, not under IPA.certificates. Perhaps in the future we will make an IPA.widget namespace and stick all of the widgets creators in there. IPA.search_generate_checkbox_td should be a method on the search table. The one place where we use that outside of search.js (in policy.js for dns) is a hack...I should know, I wrote it. I suspect much of the code in navigation can be scoped down. If you are going to add the navigation subnamesapce in navigation.js, you should do the same with the certificate namespace in certificate.js. You are currently adding it in ipa.js Lets drop the _ separating namespaces: For example nav_push_state should become IPA.nav.push_state, certificates_revoke_dialog should become IPA.certificates.revoke_dialog and so on </body> </html>