<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 02/18/2011 04:10 AM, Martin Kosek wrote:
<blockquote
cite="mid:1298020208.4638.13.camel@dhcp-25-52.brq.redhat.com"
type="cite">
<pre wrap="">On Thu, 2011-02-17 at 12:29 -0500, Adam Young wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Looks good. Only problem is on braces. we have a code standard that
is like this
IPA.something = function () {
not
IPA.something = function ()
{
This is due to Javascript being ambiguous in certain circumstances
about where it puts an implicit end of statement.
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/wiki/Javascript_Coding_Standards">https://fedorahosted.org/freeipa/wiki/Javascript_Coding_Standards</a>
</pre>
</blockquote>
<pre wrap="">
Yes. The same convention is for C/Python code. All those functions
violating a code standard were already in UI, I just moved them to
sub-namespace in the preceding patch.
Nevertheless, I went through all function definitions and I believe I
fixed all occurrences of this issue.
</pre>
<blockquote type="cite">
<pre wrap="">For name shortening, sudo.sudorule_ should be sudo.rule_
</pre>
</blockquote>
<pre wrap="">
Obviously :-)
</pre>
<blockquote type="cite">
<pre wrap="">
On the patch I sent you as an example, I broke the "View Cert"
button. I didn't test that here. Did you make sure that still
works?
</pre>
</blockquote>
<pre wrap="">
Yes, this was already fixed. It was also related to the JSLint warnings
in your patch that you mentioned earlier. But just to be sure I
double-checked this and its OK.
Patch attached. JSLint, test suite OK.
Martin
</pre>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
ACK. Pushed to master<br>
</body>
</html>