<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#ffffff">
On 04/12/2011 12:09 PM, Endi Sukma Dewata wrote:
<blockquote cite="mid:4DA4794D.4030204@redhat.com" type="cite">The
IPA.cmd() has been merged into IPA.command(). All invocations
<br>
and test cases have been converted.
<br>
<br>
Ticket #988
<br>
<br>
Passed JSLint, QUnit and Selenium tests.
<br>
<br>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
<br>
I'm not a fan of the string concatination in the command calls. I'd
prefer to do that inside the IPA.command object, the way it was done
in IPA.cmd:<br>
<br>
<br>
{<br>
entity:cert<br>
method:revoke:<br>
...<br>
}<br>
<br>
<br>
and<br>
<br>
if (spec.entity){<br>
method = spec.entity + spec.method;<br>
}else{<br>
method = spec.method;<br>
}<br>
<br>
<br>
Other than that, it looks good.<br>
<br>
<br>
<br>
</body>
</html>