<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body text="#000000" bgcolor="#ffffff"> On 04/12/2011 03:06 PM, Endi Sukma Dewata wrote: <blockquote cite="mid:4DA4A2BF.5070200@redhat.com" type="cite">The entitlement facet will show the appropriate buttons depending on the entitlement status. If it's not registered, the facet will show a Register button. If it's registered, the facet will show a Consume button. <pre wrap=""> <fieldset class="mimeAttachmentHeader"></fieldset> _______________________________________________ Freeipa-devel mailing list <a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a> <a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre> </blockquote> Please make sure all String literals come from the interal.py messages plugin. New button labels are defined in entitle.js for Consume and Register. The consume dialog should be limited to accepting only integer values: pass the validation pattern in to the text widget. that.entity = function(spec) { We are starting to see a proliferation of code like this: if (spec instanceof Object){ var factory = spec.factory || IPA.entity; entity = factory(spec); } else { var name = spec; entity = IPA.entity({name: name}); } return that; }; Can we pull it into a helper function? In dialog.js the code that.entity = IPA.get_entity(that.entity_name); should happen before init, in the initial construction of the object. The goal is to remove init functions; please don't put any more code into them from here on out. Same thing with Facet in entity.js </body> </html>