<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
This version deals with #7. Unit tests and jsl is fixed. Rebased
on top of Endi's last action-button patch.<br>
<br>
Remaining issues have to do with css and styling.<br>
<br>
Still haven't run it through the Selenium tests.<br>
<br>
<br>
On 04/21/2011 01:55 PM, Adam Young wrote:
<blockquote cite="mid:4DB06F7D.7060000@redhat.com" type="cite">Again,
have not yet run Selenium against this, so please do not push.
There are conflicts between this version and some of edewata's
patch. Additionally, there are some know issues with the
rendering on the ACI pages which I'll iron out before this gets
submitted for real.
<br>
<br>
This version solves Issues 1,2,4,5 (sort of) ,8,9,and 10 from
below.
<br>
<br>
<br>
On 04/19/2011 08:59 PM, Adam Young wrote:
<br>
<blockquote type="cite">Good points all. Only one minoir quibble,
in-line.
<br>
<br>
<br>
On 04/19/2011 05:31 PM, Endi Sukma Dewata wrote:
<br>
<blockquote type="cite">On 4/19/2011 3:07 PM, Adam Young wrote:
<br>
<blockquote type="cite">going to post this, but with a request
to hold on pushing to the repo. I
<br>
have not yet tested against selenium, and suspect that it
will break all
<br>
selenium test navigation.
<br>
</blockquote>
<br>
I've tested this patch with static data. There are some
issues:
<br>
<br>
1. Incorrect data after switching tabs.
<br>
Open Users tab, then click User Groups tab, all of the
groups will
<br>
be admin's. Refresh the page, it will show the correct
data.
<br>
<br>
2. Missing third level tabs.
<span class="action-controls"><span style="display: inline;"><a
class="ui-corner-all input_link action-button"
title="Register"><span class="ui-icon ui-icon-plus"></span></a></span></span><br>
Open HBAC tab, the Services & Service Groups are
missing.
<br>
Open SUDO tab, the Commands and Command Groups tabs are
missing.
<br>
Open Role Based Access Control, the Permissions and
Privileges tabs
<br>
are missing.
<br>
<br>
3. Default tab is not activated.
<br>
Open Users->admin, the Settings tab is inactive. It
should be bigger
<br>
than the other tabs.
<br>
<br>
4. Inconsistent position of the action buttons.
<br>
Open Users tab, observe the position of the Delete &
Add buttons.
<br>
Then click one of the users, the Reset & Update buttons
move to
<br>
the left.
<br>
<br>
5. Entity label (e.g. Users) should be used instead of entity
name
<br>
(e.g. user) as the page title (next to the buttons).
<br>
<br>
6. The page title (e.g. user) is too close to the tab groups
(e.g.
<br>
Settings). It needs some space between them.
<br>
<br>
7. The order of tab groups is not very intuitive.
<br>
Open Groups tab, click one of the groups. The default tab
group (i.e.
<br>
Settings) is located between Member and Member Of. It would
be
<br>
better to put the default tab at the left most position.
<br>
</blockquote>
<br>
While in general your observations are spot on, I'd like to
point out that this is intentional, but that the goal will be to
always open the leftmost tab. This will allow us to make
entities that are primarily containers, like netgroups, as well
as dns zone, default to the page that shows the most common use
case: manage contained entities.
<br>
<br>
<blockquote type="cite">
<br>
8. The if-then clause on entity.js:46 is unnecessary. There's
no need
<br>
to check spec.facet_group before assigning it to
that.facet_group.
<br>
<br>
9. The assignment on entity.js:296 is unnecessary. Each facet
has a
<br>
reference to the entity, so the entity header can be
accessed using
<br>
that.entity.header.
<br>
</blockquote>
<br>
<blockquote type="cite">
<br>
10. IPA.entity_header() should take a spec object instead of
attribute
<br>
list for consistency.
<br>
<br>
</blockquote>
<br>
_______________________________________________
<br>
Freeipa-devel mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<br>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a>
<br>
</blockquote>
<br>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
<br>
</body>
</html>