<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#ffffff" text="#000000"> On 04/25/2011 03:56 PM, Adam Young wrote: <blockquote cite="mid:4DB5D1ED.9070906@redhat.com" type="cite">On 04/22/2011 06:28 PM, Endi Sukma Dewata wrote: <blockquote type="cite">On 4/22/2011 2:33 PM, Adam Young wrote: <blockquote type="cite"> <blockquote type="cite"> <blockquote type="cite">Again, have not yet run Selenium against this, so please do not push. There are conflicts between this version and some of edewata's patch. Additionally, there are some know issues with the rendering on the ACI pages which I'll iron out before this gets submitted for real. This version solves Issues 1,2,4,5 (sort of) ,8,9,and 10 from below. </blockquote> </blockquote> </blockquote> <blockquote type="cite"> <blockquote type="cite">This version deals with #7. Unit tests and jsl is fixed. Rebased on top of Endi's last action-button patch. Remaining issues have to do with css and styling. Still haven't run it through the Selenium tests. </blockquote> </blockquote> <blockquote type="cite">OK, with this, the most egregious of the UI issues are fixed. While I'm sure we'll want to do more with it in the long term, I'm going to say that this is ready to go in. We'll fix the selenium tests as a follow on patch. </blockquote> Some issues: 3. Default tab is not activated. Open Users, click one of the user, the default tab is activated. Click Back to List, open the user again, the default tab is not activated. </blockquote> Fixed <blockquote type="cite"> 4. Inconsistent position of the action buttons. - Open Users tab, observe the position of the Delete & Add buttons. Then click one of the users, the Reset & Update buttons move to the left. - Open User Groups tab, observe the Add buttons, click one of the groups, the Enroll button moves to the left. </blockquote> Fixed. Had to remove some of the style info in ipa.css, but I think it was only necessary for action-panels <blockquote type="cite"> 5. Entity label should be used instead of entity name as the page title. Open Sudo -> Sudo Command Groups -> group1. The page title is "SUDOCMDGROUP:GROUP1". The problem with this is that unlike the label, entity name will not be translated. </blockquote> Done. Long term, we need both a Singular and Plural form internationalized. The name field is the single value. <blockquote type="cite"> 9. These facet.entity_header assignments are unnecessary: - entity.js:307 - details_tests.js:211 - entity_tests.js:79 Each facet has a reference to the entity, so the entity header can be accessed using that.entity.header inside the facet or facet.entity.header outside the facet. </blockquote> Leaving them for now. I am not sure that we are going to navigate by way of the entity to the header for always. Changing it broke the unit tests. I'll address this in a follow on patch that will simplify the facet API. <blockquote type="cite"> 11. Navigation error. Open User Groups tab, click one of the groups. Under Member Users, click one of the users. It will show an error dialog box (it has some typos too). </blockquote> Still a problem. </blockquote> OK, got that one fixed in this version as well (version 5) <blockquote cite="mid:4DB5D1ED.9070906@redhat.com" type="cite"> <blockquote type="cite"> 12. In the search facet there is a big space between the buttons and the results table. </blockquote> Intentional. That is the space for the tabs. Easy to remove in the future, but want it in there for now. <blockquote type="cite">13. The 3rd level tabs appear only when the HBAC, Sudo, and RBAC tabs are selected. This is causing the rest of the page to shift down. As I mentioned before, here is my suggestion: <a class="moz-txt-link-freetext" href="http://edewata.fedorapeople.org/images/mock1.png">http://edewata.fedorapeople.org/images/mock1.png</a> <a class="moz-txt-link-freetext" href="http://edewata.fedorapeople.org/images/mock2.png">http://edewata.fedorapeople.org/images/mock2.png</a> </blockquote> Going to leave it like this for now. Don't think what you have in the mock ups is quite right: We'll run past UXD and adjust <blockquote type="cite"> 14. According to the spec the buttons should be located below the 4th level tabs (facet tabs). So it should be inside a 'facet-header' instead of 'entity-header'. </blockquote> Spec needs work. It is easy enough to move things around if we decided we want to, but last conversation had the buttons above the tabs. <blockquote type="cite"> 15. Most of navigation links are on the left part of the page, but 'Back to Link' is on the right side. It's a bit inconvenient having to go all the way to the right just to go back to the search page, especially when reviewing many entries. </blockquote> Agree that it is a bit off, but it is the spec. We can revise in the future. <blockquote type="cite"> 16. Some facet group headers in the 4th level tabs are unnecessary. The Settings header above the Settings tab is redundant. The Member header above DNS resource record tab is probably inappropriate although that's how it's implemented internally. There should be a way not to show the headers. </blockquote> They are there for spacing. Once UXD reviews, we can remove them. <blockquote type="cite"> 17. Association facet doesn't set page title. Open User Groups, the page title is "USER GROUPS". Click one of the groups, it will open an association facet, the page title is unchanged. Then click Settings tab, the title changes to "GROUP:...". Click the association again, the title remains the same. </blockquote> Fixed <blockquote type="cite"> 18. Kerberos Ticket Policy and Configuration tabs don't have page titles. </blockquote> Fixed <blockquote type="cite">19. There should be a space after colon in the page title. Open Users tab, then click admin. The title is "USER:ADMIN". </blockquote> Fixed <blockquote type="cite">20. The facet groups needs to be customizable. Currently it's stored in unordered set in entity's facet_group and the order is hard- coded in get_facet() and facet_tabs(). It would be difficult to workaround this limitations in custom facets. See how facets are stored in entity. The names are stored in an ordered list (that.facets) and the instances are stored in a dictionary (that.facets_by_name). Facet groups should use a similar method to store the order and facet collections. In get_facet() the default facet should be the first facet in the first group. In facet_tabs() the tab_section should be created according to the order they are stored. </blockquote> Agreed, but we have this issue now, and so is not a regression. We'll fix in a follow on patch. <blockquote type="cite"> 21. The IPA.entity_header should be created in entity.init() instead of in entity.setup() line 305. The entity.setup() only needs to store the container in the entity.header. This also eliminates manual creations in the qunit tests. </blockquote> Long term, agreed, but init doesn't have the container, so under the current approach, we can't put it there. <blockquote type="cite"> For issues #12-16 I think we need to get UXD's feedback. </blockquote> <pre wrap=""> <fieldset class="mimeAttachmentHeader"></fieldset> _______________________________________________ Freeipa-devel mailing list <a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a> <a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre> </blockquote> </body> </html>