<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 05/23/2011 01:31 PM, Adam Young wrote:
<blockquote cite="mid:4DDA9A05.4050605@redhat.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
On 05/23/2011 01:13 PM, Adam Young wrote:
<blockquote cite="mid:4DDA95B0.6000603@redhat.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
On 05/23/2011 12:38 PM, Adam Young wrote:
<blockquote cite="mid:4DDA8D7E.9030204@redhat.com" type="cite">On
05/23/2011 12:06 PM, Endi Sukma Dewata wrote: <br>
<blockquote type="cite">On 5/23/2011 9:42 AM, Adam Young
wrote: <br>
<blockquote type="cite">Patch 227 is the automount patch
that I still am not ready to submit. <br>
This patch stands alone. <br>
</blockquote>
<br>
A few issues in IPA.get_entity(): <br>
<br>
1. It executes that.entities.get() twice. The result of the
first <br>
invocation can be stored in a variable and reused later.
The result <br>
of the factory() invocation can be assigned to the same
variable. <br>
<br>
2. It executes factory = that.entity_factories[name] twice.
The second <br>
one can be removed. <br>
<br>
Other than that it's ACKed and can be pushed after fixing
the above issues. <br>
<br>
</blockquote>
Now with fixed unit tests <br>
<pre wrap=""><fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Freeipa-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
Better navigation test<br>
<pre wrap=""><fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Freeipa-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
<br>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
ACKed in IRC by edewata and pushed to master<br>
</body>
</html>