<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 06/28/2011 04:51 PM, Adam Young wrote:
<blockquote cite="mid:4E0A3ED9.9080708@redhat.com" type="cite">On
06/28/2011 04:18 PM, Endi Sukma Dewata wrote:
<br>
<blockquote type="cite">On 6/28/2011 2:33 PM, Adam Young wrote:
<br>
<blockquote type="cite">On 06/28/2011 03:13 PM, Adam Young
wrote:
<br>
<blockquote type="cite">One known issue: uses the wrong style
for automount tabs, leaving
<br>
excess white space
<br>
</blockquote>
</blockquote>
<br>
Some issues:
<br>
<br>
1. Reloading the some pages will bring you to a different page
(i.e.
<br>
bookmarking wouldn't work). Try reloading these pages:
<br>
- Groups details/association facet
<br>
- HBAC Rule search facet
<br>
It looks like the state JS variable should be initialized
with
<br>
values from the URL.
<br>
<br>
2. The following statement in navigation.js:123:
<br>
<br>
key2.search('^'+entity)
<br>
<br>
might match more keys than we want (e.g sudo will match
sudorule,
<br>
sudocmd, sudocmdgroup). It might be better to do the matching
twice,
<br>
one for exact <value> matching and the other for
<value>-* prefix.
<br>
<br>
3. I haven't verified this, but the removeAttribute() is
supposed to be
<br>
used with DOM elements. To remove a JS object property we
should use:
<br>
<br>
delete state[key];
<br>
<br>
4. As discussed over IRC, the logic for calculating tab depth
assumes
<br>
that only the leaf nodes can be hidden. This can be slightly
improved
<br>
by moving this code
<br>
<br>
if (tab.hidden) {
<br>
depth = depth -1;
<br>
}
<br>
<br>
from navigation.js line 258 into 253. This way any hidden
tabs along
<br>
the tab hierarchy will not be counted toward depth.
<br>
<br>
5. There's a whitespace warning.
<br>
<br>
</blockquote>
<br>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
<br>
</body>
</html>