<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#ffffff" text="#000000"> On 07/06/2011 03:54 PM, Adam Young wrote: <blockquote cite="mid:4E14BD82.8080201@redhat.com" type="cite">On 07/06/2011 03:24 PM, Endi Sukma Dewata wrote: <blockquote type="cite">On 7/6/2011 10:40 AM, Adam Young wrote: <blockquote type="cite">Rebased. Also, updated the hbacrule_find.json sample data to show to the deny rules in static view </blockquote> Some issues: 1. The red 'deny' text doesn't line up with the colum header or 'allow' text. The padding-left in .hbac-deny-rule class should be removed. </blockquote> Fixed <blockquote type="cite"> 2. The link to the hbac-deny-remove.html on live server is broken. On live server the file is located under /ipa/config path instead of /ipa/html. </blockquote> Fixed. Now wokrs in both static and live server <blockquote type="cite"> 3. There are untranslated messages in hbac.js lines 1016, 1021, 1025, 1032, 1037. Please mark them with 'I18n' for later clean up. </blockquote> Not worth the effort for this <blockquote type="cite"> 4. Optional: Ideally the setup() in the accessruletype column should call the superclass' setup() then just add the 'hbac-deny-rule' class to the container. For this particular case it's not a problem because the possible values are only 'allow' or 'deny'. However if the column is linked or uses some kind of formatting it will not be rendered correctly. </blockquote> Again, since this is a short term fix, not worth the effort. <pre wrap=""> <fieldset class="mimeAttachmentHeader"></fieldset> _______________________________________________ Freeipa-devel mailing list <a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a> <a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre> </blockquote> </body> </html>