<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 07/08/2011 01:25 PM, Adam Young wrote:
<blockquote cite="mid:4E173D89.2020806@redhat.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<title></title>
On 07/08/2011 01:02 PM, Adam Young wrote:
<blockquote cite="mid:4E173831.9040307@redhat.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
On 07/08/2011 01:00 PM, Adam Young wrote:
<blockquote cite="mid:4E173794.3080304@redhat.com" type="cite">On
07/08/2011 12:40 PM, Endi Sukma Dewata wrote: <br>
<blockquote type="cite">On 7/8/2011 10:06 AM, Adam Young
wrote: <br>
<blockquote type="cite"> <br>
</blockquote>
<br>
Some issues: <br>
<br>
1. The new code in IPA.widget.test_dirty() seems to be
redundant. <br>
<br>
if ((that.values.length === 0) && <br>
(values.length === 1) && <br>
values[0] === ""){ <br>
return false; <br>
} <br>
<br>
It's already covered by a similar code above it. <br>
</blockquote>
<br>
Not quite. This happens when the widget defaults a blank
field to [""]. <br>
<blockquote type="cite"> <br>
2. The commented code in details.js:167 can be removed (and
158 too). <br>
</blockquote>
Done <br>
<blockquote type="cite"> <br>
3. Instead of returning empty array, the
details_tests.js:173 should return the overridden method's
return value. <br>
<br>
return widget.widget_save(); <br>
<br>
</blockquote>
Just keeps the test from breaking. Not really checking
anything <br>
</blockquote>
<br>
But fixed anyway<br>
<blockquote cite="mid:4E173794.3080304@redhat.com" type="cite">
<pre wrap=""><fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Freeipa-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
This time with a patch attached<br>
<pre wrap=""><fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Freeipa-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
Removed code in is_dirty check, as it deson't seem to get
triggered now.<br>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
<br>
</body>
</html>