<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 08/08/2011 09:50 AM, Petr Vobornik wrote:
<blockquote cite="mid:4E3FE9A3.5080301@redhat.com" type="cite">On
08/05/2011 11:12 PM, Adam Young wrote:
<br>
<blockquote type="cite">On 08/05/2011 09:22 AM, Petr Vobornik
wrote:
<br>
<blockquote type="cite">Redirection after changing browser
configuration
<br>
<br>
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/1502">https://fedorahosted.org/freeipa/ticket/1502</a>
<br>
<br>
Added redirection link.
<br>
<br>
Notes:
<br>
Modified preferences.html.template to be able to respond to
the
<br>
configuration change.
<br>
<br>
Because of security politics page cannot be automatically
redirected.
<br>
(has to redirect top frame). -> Message with link was
added.
<br>
<br>
Redirection link has to use absolute url because page is
situated in
<br>
object frame and its location points to jar archive.
<br>
<br>
<br>
<br>
_______________________________________________
<br>
Freeipa-devel mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<br>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a>
<br>
</blockquote>
Looks good. The formatting of the Link at the end is wrapped
around
<br>
across multiple lines. Of course, right now, we are missing the
css
<br>
there, so maybe it is due to the stylesheet error.
<br>
If you can put the message on one line and the link on the
second, I'd
<br>
consider it ACKed
<br>
<br>
<br>
_______________________________________________
<br>
Freeipa-devel mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<br>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a>
<br>
</blockquote>
<br>
The link alone can't fit on a single line.
<br>
- I have expanded the object's area. (and cleaned css from
trailing white spaces in the process)
<br>
- Added css in preferences template in order to look good. In the
future it would be better to remove these css and reuse
ipa_error.css. But it has to be included in the jar (I don't know
where to do it).
<br>
- Corrected object tag ending so "Back to the Web UI" link is
displayed even if user has not configured Firefox (this can be
useful for other browser's users or if user don't want to
configure browser. But it is redundant with the link which is
displayed after configuration.).
<br>
<br>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
OK, ACKed and pushed to master. <br>
<br>
edewata is working on a fix for the CSS for the error/config pages.
Please make sure to integrate that fix with tuning the layout issues
for this one.<br>
<br>
<br>
</body>
</html>