<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 11/18/2011 02:18 PM, Jiri Kuncar wrote:
<blockquote
cite="mid:617d88cb-b991-4eb0-90ee-c8ec7119e994@zmail13.collab.prod.int.phx2.redhat.com"
type="cite">
<pre wrap="">Bind-dyndb-ldap: Don't fail to load zone when it contains invalid records.</pre>
</blockquote>
Your patch seems fine for me, thanks. Please check my comments
inside the patch.<br>
<br>
Regards, Adam<br>
<br>
<blockquote
cite="mid:617d88cb-b991-4eb0-90ee-c8ec7119e994@zmail13.collab.prod.int.phx2.redhat.com"
type="cite">
<pre wrap="">
Needed by ticket #36 <a class="moz-txt-link-freetext" href="https://fedorahosted.org/bind-dyndb-ldap/ticket/36">https://fedorahosted.org/bind-dyndb-ldap/ticket/36</a></pre>
<br>
<fieldset class="mimeAttachmentHeader"><legend
class="mimeAttachmentHeaderName">0001-Skip-bad-records.patch</legend></fieldset>
<br>
<pre wrap="">From 37a8430b4a5555d33fc727a6b6a19998710b37da Mon Sep 17 00:00:00 2001
From: Jiri Kuncar <a class="moz-txt-link-rfc2396E" href="mailto:jkuncar@redhat.com"><jkuncar@redhat.com></a>
Date: Fri, 18 Nov 2011 08:04:53 -0500
Subject: [PATCH] Skip bad records.
Signed-off-by: Jiri Kuncar <a class="moz-txt-link-rfc2396E" href="mailto:jkuncar@redhat.com"><jkuncar@redhat.com></a>
---
src/ldap_helper.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/ldap_helper.c b/src/ldap_helper.c
index 6fb57ce..029398c 100644
--- a/src/ldap_helper.c
+++ b/src/ldap_helper.c
@@ -1080,9 +1080,11 @@ ldapdb_rdatalist_get(isc_mem_t *mctx, ldap_instance_t *ldap_inst, dns_name_t *na
for (entry = HEAD(ldap_conn->ldap_entries);
entry != NULL;
entry = NEXT(entry, link)) {
- CHECK(ldap_parse_rrentry(mctx, entry, ldap_conn,
- origin, ldap_inst->fake_mname,
- string, rdatalist));
+ if (ISC_R_SUCCESS != ldap_parse_rrentry(mctx, entry, ldap_conn,
+ origin, ldap_inst->fake_mname,
+ string, rdatalist)) {</pre>
</blockquote>
Please keep consistency with rest of code. Use if (function() !=
result), not if (result != function()).<br>
<br>
<blockquote
cite="mid:617d88cb-b991-4eb0-90ee-c8ec7119e994@zmail13.collab.prod.int.phx2.redhat.com"
type="cite">
<pre wrap="">
+ log_error("Failed to parse RR entry");</pre>
</blockquote>
What about log_error("Failed to parse RR entry (%s)", string); ?
This will help admin to track which RR is bad.<br>
<br>
<blockquote
cite="mid:617d88cb-b991-4eb0-90ee-c8ec7119e994@zmail13.collab.prod.int.phx2.redhat.com"
type="cite">
<pre wrap="">
+ }
}
/* Cache RRs */
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
<br>
</body>
</html>