From f34d6e7ca91731cbb09d19bbf73c12d663da731d Mon Sep 17 00:00:00 2001
From: Endi Sukma Dewata <edewata@redhat.com>
Date: Fri, 18 Nov 2011 19:47:39 -0600
Subject: [PATCH] Refactored facet.load().

The load() in IPA.facet has been modified to accept the complete
data returned by the server instead of just the result. This is
needed by HBAC Test to access other attributes returned in the
test result.

Ticket #388
---
 install/ui/add.js                |   32 ++--
 install/ui/association.js        |   43 +++---
 install/ui/automount.js          |   58 +++++---
 install/ui/details.js            |  102 ++++++-------
 install/ui/dns.js                |  301 ++++++++++++++++++++++----------------
 install/ui/entitle.js            |   36 ++---
 install/ui/facet.js              |  232 ++++++++++++++++-------------
 install/ui/group.js              |   14 +-
 install/ui/hbac.js               |   16 +--
 install/ui/search.js             |   65 +++------
 install/ui/sudo.js               |   16 +--
 install/ui/test/details_tests.js |    6 +-
 install/ui/user.js               |    5 +-
 13 files changed, 480 insertions(+), 446 deletions(-)

diff --git a/install/ui/add.js b/install/ui/add.js
index c9d5e46bb44bafd087fe214be06adb0ecf3d180b..0433e30c2d6daf86750f042de1c3f54149e17d33 100644
--- a/install/ui/add.js
+++ b/install/ui/add.js
@@ -30,7 +30,6 @@ IPA.entity_adder_dialog = function(spec) {
     var that = IPA.dialog(spec);
 
     that.method = spec.method || 'add';
-    that.pre_execute_hook = spec.pre_execute_hook;
     that.on_error = spec.on_error ;
     that.retry = typeof spec.retry !== 'undefined' ? spec.retry : true;
     that.command = null;
@@ -107,26 +106,18 @@ IPA.entity_adder_dialog = function(spec) {
         IPA.nav.show_entity_page(that.entity, 'default', pkey);
     }
 
-    that.add = function(on_success, on_error) {
+    that.create_add_command = function(record) {
 
         var pkey_name = that.entity.metadata.primary_key;
 
         var command = IPA.command({
             entity: that.entity.name,
             method: that.method,
-            retry: that.retry,
-            on_success: on_success,
-            on_error: on_error
+            retry: that.retry
         });
-        that.command = command;
 
         command.add_args(that.entity.get_primary_key_prefix());
 
-        if (!that.validate()) return;
-
-        var record = {};
-        that.save(record);
-
         var sections = that.sections.values;
         for (var i=0; i<sections.length; i++) {
             var section = sections[i];
@@ -150,13 +141,21 @@ IPA.entity_adder_dialog = function(spec) {
             }
         }
 
-        //alert(JSON.stringify(command.to_json()));
+        return command;
+    };
 
-        if (that.pre_execute_hook) {
-            that.pre_execute_hook(command);
-        }
+    that.add = function(on_success, on_error) {
 
-        command.execute();
+        if (!that.validate()) return;
+
+        var record = {};
+        that.save(record);
+
+        that.command = that.create_add_command(record);
+        that.command.on_success = on_success;
+        that.command.on_error = on_error;
+
+        that.command.execute();
     };
 
     that.create = function() {
@@ -179,6 +178,7 @@ IPA.entity_adder_dialog = function(spec) {
 
     // methods that should be invoked by subclasses
     that.entity_adder_dialog_create = that.create;
+    that.entity_adder_dialog_create_add_command = that.create_add_command;
 
     init();
 
diff --git a/install/ui/association.js b/install/ui/association.js
index 553966eb93c12c92a8b592bd1054ea7615b153a3..5dc5d5e5d00e7461c04e7f7bad181453a50a9d79 100644
--- a/install/ui/association.js
+++ b/install/ui/association.js
@@ -750,11 +750,6 @@ IPA.association_facet = function (spec) {
         var column;
         var i;
 
-        var adder_columns = spec.adder_columns || [];
-        for (i=0; i<adder_columns.length; i++) {
-            that.create_adder_column(adder_columns[i]);
-        }
-
         var pkey_name;
         if (that.other_entity) {
             pkey_name = IPA.metadata.objects[that.other_entity].primary_key;
@@ -762,12 +757,24 @@ IPA.association_facet = function (spec) {
 
         if (!that.columns.length){
             that.create_column({
-                name: pkey_name,
-                primary_key: true,
-                link: spec.link
+                name: pkey_name
             });
         }
 
+        var columns = that.columns.values;
+        for (i=0; i<columns.length; i++) {
+            column = columns[i];
+            column.link = spec.link;
+        }
+
+        var other_entity = IPA.get_entity(that.other_entity);
+        that.init_table(other_entity);
+
+        var adder_columns = spec.adder_columns || [];
+        for (i=0; i<adder_columns.length; i++) {
+            that.create_adder_column(adder_columns[i]);
+        }
+
         if (!that.adder_columns.length) {
             that.create_adder_column({
                 name: pkey_name,
@@ -780,9 +787,6 @@ IPA.association_facet = function (spec) {
             column = adder_columns[i];
             column.entity_name = that.other_entity;
         }
-
-        var other_entity = IPA.get_entity(that.other_entity);
-        that.init_table(other_entity);
     };
 
     that.get_records_command_name = function() {
@@ -879,10 +883,6 @@ IPA.association_facet = function (spec) {
         }
     };
 
-    that.create_content = function(container) {
-        that.table.create(container);
-    };
-
     that.show = function() {
         that.facet_show();
 
@@ -900,7 +900,7 @@ IPA.association_facet = function (spec) {
         title = title.replace('${primary_key}', pkey);
         title = title.replace('${other_entity}', label);
 
-        var pkeys = that.data[that.get_attribute_name()];
+        var pkeys = that.data.result.result[that.get_attribute_name()];
 
         var dialog = IPA.association_adder_dialog({
             title: title,
@@ -992,8 +992,8 @@ IPA.association_facet = function (spec) {
         dialog.open(that.container);
     };
 
-    that.load_pkeys = function(result) {
-        that.pkeys = that.data[that.get_attribute_name()] || [];
+    that.get_pkeys = function(data) {
+        return data.result.result[that.get_attribute_name()] || [];
     };
 
     that.refresh = function() {
@@ -1017,10 +1017,13 @@ IPA.association_facet = function (spec) {
         });
 
         command.on_success = function(data, text_status, xhr) {
-            that.load(data.result.result);
+            that.load(data);
         };
 
-        command.on_error = that.on_error;
+        command.on_error = function(xhr, text_status, error_thrown) {
+            that.redirect_error(error_thrown);
+            that.report_error(error_thrown);
+        };
 
         command.execute();
     };
diff --git a/install/ui/automount.js b/install/ui/automount.js
index c0e4b89f248f54e012c4c70d26f79a828a71750a..47eafe35a83d67a5ab487c185b0adbc5162b2014 100644
--- a/install/ui/automount.js
+++ b/install/ui/automount.js
@@ -160,6 +160,7 @@ IPA.automount.key_entity = function(spec) {
 
         that.builder.containing_entity('automountmap').
         details_facet({
+            factory: IPA.automount.key_details_facet,
             sections: [
                 {
                     name:'identity',
@@ -173,24 +174,7 @@ IPA.automount.key_entity = function(spec) {
                     ]
                 }
             ],
-            disable_breadcrumb: false,
-            pre_execute_hook : function (command){
-                var entity_name = this.entity_name;
-                var info = IPA.nav.get_state(entity_name + '-info');
-                var key = IPA.nav.get_state(entity_name + '-pkey');
-
-
-                if (command.args.length ==3){
-                    command.args.pop();
-                }
-                if (command.method === 'mod'){
-                    command.options['newautomountinformation'] =
-                        command.options['automountinformation'];
-
-                }
-                command.options['automountkey'] = key;
-                command.options['automountinformation'] = info;
-            }
+            disable_breadcrumb: false
         }).
         adder_dialog({
             show_edit_page : function(entity, result){
@@ -210,6 +194,44 @@ IPA.automount.key_entity = function(spec) {
     return that;
 };
 
+IPA.automount.key_details_facet = function(spec) {
+
+    var that = IPA.details_facet(spec);
+
+    that.create_update_command = function() {
+
+        var command = that.details_facet_create_update_command();
+
+        command.args.pop();
+
+        var key = IPA.nav.get_state(that.entity.name + '-pkey');
+        var info = IPA.nav.get_state(that.entity.name + '-info');
+
+        command.options.newautomountinformation = command.options.automountinformation;
+        command.options.automountkey = key;
+        command.options.automountinformation = info;
+
+        return command;
+    };
+
+    that.create_refresh_command = function() {
+
+        var command = that.details_facet_create_refresh_command();
+
+        command.args.pop();
+
+        var key = IPA.nav.get_state(that.entity.name + '-pkey');
+        var info = IPA.nav.get_state(that.entity.name + '-info');
+
+        command.options.automountkey = key;
+        command.options.automountinformation = info;
+
+        return command;
+    };
+
+    return that;
+};
+
 IPA.automount_key_column = function(spec) {
 
     var that = IPA.column(spec);
diff --git a/install/ui/details.js b/install/ui/details.js
index 440a9b7d9618f279c5c941a51bd0bffd12f4faa6..f7bb226b4a50551fd797c1842f3a9d8fdda58fe1 100644
--- a/install/ui/details.js
+++ b/install/ui/details.js
@@ -319,8 +319,6 @@ IPA.details_facet = function(spec) {
 
     var that = IPA.facet(spec);
     that.entity = spec.entity;
-    that.pre_execute_hook = spec.pre_execute_hook;
-    that.post_update_hook = spec.post_update_hook;
     that.update_command_name = spec.update_command_name || 'mod';
     that.command_mode = spec.command_mode || 'save'; // [save, info]
 
@@ -393,7 +391,7 @@ IPA.details_facet = function(spec) {
             if (!pkey_name){
                 return pkey;
             }
-            var pkey_val = that.data[pkey_name];
+            var pkey_val = that.data.result.result[pkey_name];
             if (pkey_val instanceof Array) {
                 pkey.push(pkey_val[0]);
             } else {
@@ -616,7 +614,7 @@ IPA.details_facet = function(spec) {
         var sections = that.sections.values;
         for (var i=0; i<sections.length; i++) {
             var section = sections[i];
-            section.load(data);
+            section.load(data.result.result);
         }
         that.enable_update(false);
     };
@@ -677,17 +675,7 @@ IPA.details_facet = function(spec) {
 
 
     that.on_update_success = function(data, text_status, xhr) {
-
-        if (data.error)
-            return;
-
-        if (that.post_update_hook) {
-            that.post_update_hook(data, text_status);
-            return;
-        }
-
-        var result = data.result.result;
-        that.load(result);
+        that.load(data);
     };
 
     that.on_update_error = function(xhr, text_status, error_thrown) {
@@ -705,7 +693,7 @@ IPA.details_facet = function(spec) {
         }
     };
 
-    that.create_fields_update_command = function(update_info, on_win, on_fail) {
+    that.create_fields_update_command = function(update_info) {
 
         var args = that.get_primary_key();
         var command = IPA.command({
@@ -715,9 +703,7 @@ IPA.details_facet = function(spec) {
             options: {
                 all: true,
                 rights: true
-            },
-            on_success: on_win,
-            on_error: on_fail
+            }
         });
 
         //set command options
@@ -726,12 +712,10 @@ IPA.details_facet = function(spec) {
         return command;
     };
 
-    that.create_batch_update_command = function(update_info, on_win, on_fail) {
+    that.create_batch_update_command = function(update_info) {
 
         var batch = IPA.batch_command({
-            'name': that.entity.name + '_details_update',
-            'on_success': on_win,
-            'on_error': on_fail
+            name: that.entity.name + '_details_update'
         });
 
         var new_update_info = IPA.update_info_builder.copy(update_info);
@@ -761,21 +745,11 @@ IPA.details_facet = function(spec) {
         dialog.open();
     };
 
-    that.update = function(on_win, on_fail) {
-
-        var on_success = function(data, text_status, xhr) {
-            that.on_update_success(data, text_status, xhr);
-            if (on_win) on_win.call(this, data, text_status, xhr);
-        };
-
-        var on_error = function(xhr, text_status, error_thrown) {
-            that.on_update_error(xhr, text_status, error_thrown);
-            if (on_fail) on_fail.call(this, xhr, text_status, error_thrown);
-        };
+    that.create_update_command = function() {
 
         var command, update_info;
 
-        if(that.command_mode === 'info') {
+        if (that.command_mode === 'info') {
             update_info = that.get_update_info();
         } else {
             update_info = that.save_as_update_info(true, true);
@@ -783,19 +757,28 @@ IPA.details_facet = function(spec) {
 
         if (update_info.commands.length <= 0) {
             //normal command
-            command = that.create_fields_update_command(update_info,
-                                                        on_success,
-                                                        on_error);
+            command = that.create_fields_update_command(update_info);
         } else {
             //batch command
-            command = that.create_batch_update_command(update_info,
-                                                        on_success,
-                                                        on_error);
+            command = that.create_batch_update_command(update_info);
         }
 
-        if (that.pre_execute_hook){
-            that.pre_execute_hook(command);
-        }
+        return command;
+    };
+
+    that.update = function(on_success, on_error) {
+
+        var command = that.create_update_command();
+
+        command.on_success = function(data, text_status, xhr) {
+            that.on_update_success(data, text_status, xhr);
+            if (on_success) on_success.call(this, data, text_status, xhr);
+        };
+
+        command.on_error = function(xhr, text_status, error_thrown) {
+            that.on_update_error(xhr, text_status, error_thrown);
+            if (on_error) on_error.call(this, xhr, text_status, error_thrown);
+        };
 
         command.execute();
     };
@@ -804,9 +787,7 @@ IPA.details_facet = function(spec) {
         return that.entity.name+'_show';
     };
 
-    that.refresh = function() {
-
-        that.pkey = IPA.nav.get_state(that.entity.name+'-pkey');
+    that.create_refresh_command = function() {
 
         var command = IPA.command({
             name: that.get_refresh_command_name(),
@@ -817,21 +798,30 @@ IPA.details_facet = function(spec) {
 
         if (that.pkey) {
             command.args = that.get_primary_key(true);
+        }
 
-        } else if (that.entity.redirect_facet) {
+        return command;
+    };
+
+    that.refresh = function() {
+
+        that.pkey = IPA.nav.get_state(that.entity.name+'-pkey');
+
+        if (!that.pkey && that.entity.redirect_facet) {
             that.redirect();
             return;
         }
 
+        var command = that.create_refresh_command();
+
         command.on_success = function(data, text_status, xhr) {
-            that.load(data.result.result);
+            that.load(data);
         };
 
-        command.on_error = that.on_error;
-
-        if (that.pre_execute_hook) {
-            that.pre_execute_hook(command);
-        }
+        command.on_error = function(xhr, text_status, error_thrown) {
+            that.redirect_error(error_thrown);
+            that.report_error(error_thrown);
+        };
 
         command.execute();
     };
@@ -863,7 +853,9 @@ IPA.details_facet = function(spec) {
 
     that.add_sections(spec.sections);
 
-    that.details_facet_create_content = that.create_content;
+    // methods that should be invoked by subclasses
+    that.details_facet_create_update_command = that.create_update_command;
+    that.details_facet_create_refresh_command = that.create_refresh_command;
     that.details_facet_load = that.load;
 
     return that;
diff --git a/install/ui/dns.js b/install/ui/dns.js
index 9fc3c3c3edec85e6882fbcbe78d09471f08f2ffa..b90cee850fca27298125a4d842930312cdffe25a 100644
--- a/install/ui/dns.js
+++ b/install/ui/dns.js
@@ -462,154 +462,158 @@ IPA.dns.record_entity = function(spec) {
 
         that.builder.containing_entity('dnszone').
         details_facet({
-            post_update_hook:function(data){
-                var result = data.result.result;
-                 if (result.idnsname) {
-                    this.load(result);
-                } else {
-                    this.reset();
-                    var dialog = IPA.dnsrecord_redirection_dialog();
-                    dialog.open(this.container);
-                }
-            },
+            factory: IPA.dns.record_details_facet,
             disable_breadcrumb: false,
-            sections:[
-               {
-                   name:'identity',
-                   label: IPA.messages.details.identity,
-                   fields:[
-                       {
-                           factory:IPA.dnsrecord_host_link_widget,
-                           name: 'idnsname',
-                           other_entity:'host',
-                           label:IPA.get_entity_param(
-                               'dnsrecord', 'idnsname').label
-                       }
+            sections: [
+                {
+                    name: 'identity',
+                    label: IPA.messages.details.identity,
+                    fields: [
+                        {
+                            factory: IPA.dnsrecord_host_link_widget,
+                            name: 'idnsname',
+                            other_entity: 'host',
+                            label: IPA.get_entity_param(
+                                'dnsrecord', 'idnsname').label
+                        }
                    ]
-               },
+                },
                 {
-                    name:'standard',
-                    label:IPA.messages.objects.dnsrecord.standard,
-                    fields:[
-                        { factory: IPA.multivalued_text_widget,
-                          name: 'arecord',
-                          metadata: {primary_key: false},
-                          label:'A'
+                    name: 'standard',
+                    label: IPA.messages.objects.dnsrecord.standard,
+                    fields: [
+                        {
+                            factory: IPA.multivalued_text_widget,
+                            name: 'arecord',
+                            metadata: { primary_key: false },
+                            label: 'A'
                         },
-                        { factory: IPA.multivalued_text_widget,
-                          name: 'aaaarecord',
-                          metadata: {primary_key: false},
-                          label:'AAAA'
+                        {
+                            factory: IPA.multivalued_text_widget,
+                            name: 'aaaarecord',
+                            metadata: { primary_key: false },
+                            label: 'AAAA'
                         },
-                        { factory: IPA.multivalued_text_widget,
-                          name: 'ptrrecord',
-                          metadata: {primary_key: false},
-                          label:'PTR'
+                        {
+                            factory: IPA.multivalued_text_widget,
+                            name: 'ptrrecord',
+                            metadata: { primary_key: false },
+                            label: 'PTR'
                         },
-                        { factory: IPA.multivalued_text_widget,
-                          name: 'srvrecord',
-                          metadata: {primary_key: false},
-                          label:'SRV'
+                        {
+                            factory: IPA.multivalued_text_widget,
+                            name: 'srvrecord',
+                            metadata: { primary_key: false },
+                            label: 'SRV'
                         },
-                        { factory: IPA.multivalued_text_widget,
-                          name: 'txtrecord',
-                          metadata: {primary_key: false},
-                          label:'TXT'
+                        {
+                            factory: IPA.multivalued_text_widget,
+                            name: 'txtrecord',
+                            metadata: { primary_key: false },
+                            label: 'TXT'
                         },
-                        { factory: IPA.multivalued_text_widget,
-                          name: 'cnamerecord',
-                          metadata: {primary_key: false},
-                          label:'CNAME'
+                        {
+                            factory: IPA.multivalued_text_widget,
+                            name: 'cnamerecord',
+                            metadata: { primary_key: false },
+                            label: 'CNAME'
                         },
-                        { factory: IPA.multivalued_text_widget,
-                          label:'MX',
-                          metadata: {primary_key: false},
-                          name:"mxrecord"
+                        {
+                            factory: IPA.multivalued_text_widget,
+                            name: 'mxrecord',
+                            metadata: { primary_key: false },
+                            label: 'MX'
                         },
-                        { factory: IPA.multivalued_text_widget,
-                          label:'NS',
-                          metadata: {primary_key: false},
-                          name:"nsrecord"
+                        {
+                            factory: IPA.multivalued_text_widget,
+                            name: 'nsrecord',
+                            metadata: { primary_key: false },
+                            label: 'NS'
                         }
-
                     ]
                 },
                 {
-                    name:'unusual',
-                    label:IPA.messages.objects.dnsrecord.other,
-                    fields:[
-                        { factory: IPA.multivalued_text_widget,
-                          label:'AFSDB',
-                          metadata: {primary_key: false},
-                          name: "afsdbrecord"
-                        },
-                        { factory: IPA.multivalued_text_widget,
-                          label:'CERT',
-                          metadata: {primary_key: false},
-                          name:"certrecord"
-                        },
-                        { factory: IPA.multivalued_text_widget,
-                          label:'DNAME',
-                          metadata: {primary_key: false},
-                          name:"dnamerecord"
-                        },
-                        { factory: IPA.multivalued_text_widget,
-                          label:'DSRECORD',
-                          metadata: {primary_key: false},
-                          name:"dsrecord"
-                        },
-                        { factory: IPA.multivalued_text_widget,
-                          label:'KEY',
-                          metadata: {primary_key: false},
-                          name:"keyrecord"
-                        },
-                        { factory: IPA.multivalued_text_widget,
-                          label:'KX',
-                          metadata: {primary_key: false},
-                          name:"kxrecord"
-                        },
-                        { factory: IPA.multivalued_text_widget,
-                          label:'LOC',
-                          metadata: {primary_key: false},
-                          name:"locrecord"
-                        },
-                        { factory: IPA.multivalued_text_widget,
-                          label:'NAPTR',
-                          name:"naptrrecord"
-                        },
-                        { factory: IPA.multivalued_text_widget,
-                          label:'NSEC',
-                          metadata: {primary_key: false},
-                          name:"nsecrecord"
-                        },
-                        { factory: IPA.multivalued_text_widget,
-                          label:'RRSIG',
-                          metadata: {primary_key: false},
-                          name:"rrsigrecord"
-                        },
-                        { factory: IPA.multivalued_text_widget,
-                          label:'SIG',
-                          metadata: {primary_key: false},
-                          name:"sigrecord"
-                        },
-                        { factory: IPA.multivalued_text_widget,
-                          label:'SSHFP',
-                          metadata: {primary_key: false},
-                          name:"sshfprecord"
+                    name: 'other',
+                    label: IPA.messages.objects.dnsrecord.other,
+                    fields: [
+                        {
+                            factory: IPA.multivalued_text_widget,
+                            name: 'afsdbrecord',
+                            metadata: { primary_key: false },
+                            label: 'AFSDB'
+                        },
+                        {
+                            factory: IPA.multivalued_text_widget,
+                            name: 'certrecord',
+                            metadata: { primary_key: false },
+                            label: 'CERT'
+                        },
+                        {
+                            factory: IPA.multivalued_text_widget,
+                            name: 'dnamerecord',
+                            metadata: { primary_key: false },
+                            label: 'DNAME'
+                        },
+                        {
+                            factory: IPA.multivalued_text_widget,
+                            name: 'dsrecord',
+                            metadata: { primary_key: false },
+                            label: 'DSRECORD'
+                        },
+                        {
+                            factory: IPA.multivalued_text_widget,
+                            name: 'keyrecord',
+                            metadata: { primary_key: false },
+                            label: 'KEY'
+                        },
+                        {
+                            factory: IPA.multivalued_text_widget,
+                            name: 'kxrecord',
+                            metadata: { primary_key: false },
+                            label: 'KX'
+                        },
+                        {
+                            factory: IPA.multivalued_text_widget,
+                            name: 'locrecord',
+                            metadata: { primary_key: false },
+                            label: 'LOC'
+                        },
+                        {
+                            factory: IPA.multivalued_text_widget,
+                            name: 'naptrrecord',
+                            metadata: { primary_key: false },
+                            label: 'NAPTR'
+                        },
+                        {
+                            factory: IPA.multivalued_text_widget,
+                            name: 'nsecrecord',
+                            metadata: { primary_key: false },
+                            label: 'NSEC'
+                        },
+                        {
+                            factory: IPA.multivalued_text_widget,
+                            name: 'rrsigrecord',
+                            metadata: { primary_key: false },
+                            label: 'RRSIG'
+                        },
+                        {
+                            factory: IPA.multivalued_text_widget,
+                            name: 'sigrecord',
+                            metadata: { primary_key: false },
+                            label: 'SIG'
+                        },
+                        {
+                            factory: IPA.multivalued_text_widget,
+                            name: 'sshfprecord',
+                            metadata: { primary_key: false },
+                            label: 'SSHFP'
                         }
                     ]
                 }
             ]
         }).
         adder_dialog({
-            pre_execute_hook: function(command) {
-                var record_type = command.options.record_type;
-                var record_data = command.options.record_data;
-
-                delete command.options.record_type;
-                delete command.options.record_data;
-                command.options[record_type] = record_data;
-            },
+            factory: IPA.dns.record_adder_dialog,
             fields: [
                 'idnsname',
                 {
@@ -630,6 +634,47 @@ IPA.dns.record_entity = function(spec) {
     return that;
 };
 
+IPA.dns.record_adder_dialog = function(spec) {
+
+    var that = IPA.entity_adder_dialog(spec);
+
+    that.create_add_command = function(record) {
+
+        var command = that.entity_adder_dialog_create_add_command(record);
+
+        var record_type = command.options.record_type;
+        var record_data = command.options.record_data;
+
+        delete command.options.record_type;
+        delete command.options.record_data;
+
+        command.options[record_type] = record_data;
+
+        return command;
+    };
+
+    return that;
+};
+
+IPA.dns.record_details_facet = function(spec) {
+
+    var that = IPA.details_facet(spec);
+
+    that.on_update_success = function(data, text_status, xhr) {
+
+        if (!data.result.result.idnsname) {
+            that.reset();
+            var dialog = IPA.dnsrecord_redirection_dialog();
+            dialog.open(that.container);
+            return;
+        }
+
+        that.load(data);
+    };
+
+    return that;
+};
+
 IPA.dnsrecord_redirection_dialog = function(spec) {
     spec = spec || {};
     spec.title = spec.title || IPA.messages.dialogs.redirection;
diff --git a/install/ui/entitle.js b/install/ui/entitle.js
index 17dc9230f3580e685615e00f37c953fe907d243e..4d72f5770558850b6a557a114ba88743e1818fd7 100644
--- a/install/ui/entitle.js
+++ b/install/ui/entitle.js
@@ -85,8 +85,8 @@ IPA.entitle.entity = function(spec) {
                 }
             ]
         }).
-        search_facet({
-            factory: IPA.entitle.search_facet,
+        facet({
+            factory: IPA.entitle.certificates_facet,
             name: 'certificates',
             label: IPA.messages.objects.entitle.certificates,
             facet_group: 'certificates',
@@ -365,7 +365,7 @@ IPA.entitle.details_facet = function(spec) {
                 // that.register_offline_button.css('display', 'none');
             }
 
-            that.load(data.result.result);
+            that.load(data);
 
             summary.empty();
         }
@@ -375,13 +375,15 @@ IPA.entitle.details_facet = function(spec) {
             that.register_online_button.css('display', 'inline');
             // that.register_offline_button.css('display', 'inline');
 
-            var result = {
+            var data = {};
+            data.result = {};
+            data.result.result = {
                 uuid: '',
                 product: '',
                 quantity: 0,
                 consumed: 0
             };
-            that.load(result);
+            that.load(data);
 
             summary.empty();
             summary.append(error_thrown.name+': '+error_thrown.message);
@@ -395,13 +397,17 @@ IPA.entitle.details_facet = function(spec) {
     return that;
 };
 
-IPA.entitle.search_facet = function(spec) {
+IPA.entitle.certificates_facet = function(spec) {
 
     spec = spec || {};
     spec.disable_facet_tabs = false;
     spec.selectable = false;
 
-    var that = IPA.search_facet(spec);
+    var that = IPA.table_facet(spec);
+
+    var init = function() {
+        that.init_table(that.entity);
+    };
 
     that.create_header = function(container) {
 
@@ -455,16 +461,7 @@ IPA.entitle.search_facet = function(spec) {
                 that.import_button.css('display', 'inline');
             }
 
-            that.load(data.result.result);
-
-            var summary = $('span[name=summary]', that.table.tfoot).empty();
-            if (data.result.truncated) {
-                var message = IPA.messages.search.truncated;
-                message = message.replace('${counter}', data.result.count);
-                summary.text(message);
-            } else {
-                summary.text(data.result.summary);
-            }
+            that.load(data);
         }
 
         function on_error(xhr, text_status, error_thrown) {
@@ -472,8 +469,7 @@ IPA.entitle.search_facet = function(spec) {
             that.consume_button.css('display', 'none');
             that.import_button.css('display', 'inline');
 
-            var summary = $('span[name=summary]', that.table.tfoot).empty();
-            summary.append(error_thrown.name+': '+error_thrown.message);
+            that.table.summary.text(error_thrown.name+': '+error_thrown.message);
         }
 
         that.entity.get_status(
@@ -485,6 +481,8 @@ IPA.entitle.search_facet = function(spec) {
             on_error);
     };
 
+    init();
+
     return that;
 };
 
diff --git a/install/ui/facet.js b/install/ui/facet.js
index 3a1ae92edc6b20515fc29627b32c2d1442aaa0ac..71ad5c08b2c1ea9105dfff3d5b71673f8e36d348 100644
--- a/install/ui/facet.js
+++ b/install/ui/facet.js
@@ -107,7 +107,7 @@ IPA.facet = function(spec) {
 
     that.load = function(data) {
         that.data = data;
-        that.header.load(data);
+        that.header.load(data.result.result);
     };
 
     that.clear = function() {
@@ -141,21 +141,20 @@ IPA.facet = function(spec) {
             that.entity.redirect_facet);
     };
 
-    var redirect_errors = [4001];
+    var redirect_error_codes = [4001];
 
-    that.on_error = function(xhr, text_status, error_thrown) {
+    that.redirect_error = function(error_thrown) {
 
         /*If the error is in talking to the server, don't attempt to redirect,
           as there is nothing any other facet can do either. */
         if (that.entity.redirect_facet) {
-            for (var i=0; i<redirect_errors.length; i++) {
-                if (error_thrown.code === redirect_errors[i]) {
+            for (var i=0; i<redirect_error_codes.length; i++) {
+                if (error_thrown.code === redirect_error_codes[i]) {
                     that.redirect();
                     return;
                 }
             }
         }
-        that.report_error(error_thrown);
     };
 
 
@@ -439,22 +438,130 @@ IPA.table_facet = function(spec) {
         return that;
     };
 
-    that.load = function(result) {
-        that.facet_load(result);
+    that.create_content = function(container) {
+        that.table.create(container);
+    };
+
+    that.load = function(data) {
+        that.facet_load(data);
 
         that.table.current_page = 1;
         that.table.total_pages = 1;
 
         if (that.pagination) {
-            that.table.load_page(result);
+            that.load_page(data);
         } else {
-            that.table.load(result);
+            that.load_all(data);
         }
 
         that.table.current_page_input.val(that.table.current_page);
         that.table.total_pages_span.text(that.table.total_pages);
+    };
+
+
+    that.load_all = function(data) {
+
+        that.table.empty();
+
+        var result = data.result.result;
+        for (var i=0; i<result.length; i++) {
+            var record = that.table.get_record(result[i], 0);
+            that.table.add_record(record);
+        }
 
         that.table.unselect_all();
+
+        if (data.result.truncated) {
+            var message = IPA.messages.search.truncated;
+            message = message.replace('${counter}', data.result.count);
+            that.table.summary.text(message);
+        } else {
+            that.table.summary.text(data.result.summary);
+        }
+    };
+
+    that.get_pkeys = function(data){
+        return [];
+    };
+
+    that.load_page = function(data) {
+
+        that.pkeys = that.get_pkeys(data);
+
+        if (that.pkeys.length) {
+            that.table.total_pages =
+                Math.ceil(that.pkeys.length / that.table.page_length);
+        } else {
+            that.table.total_pages = 1;
+        }
+
+        delete that.table.current_page;
+
+        var state = {};
+        var page = parseInt(IPA.nav.get_state(that.entity_name+'-page'), 10) || 1;
+        if (page < 1) {
+            state[that.entity_name+'-page'] = 1;
+            IPA.nav.push_state(state);
+            return;
+        } else if (page > that.table.total_pages) {
+            state[that.entity_name+'-page'] = that.table.total_pages;
+            IPA.nav.push_state(state);
+            return;
+        }
+        that.table.current_page = page;
+
+        if (!that.pkeys || !that.pkeys.length) {
+            that.table.empty();
+            that.table.summary.text(IPA.messages.association.no_entries);
+            that.table.unselect_all();
+            return;
+        }
+
+        that.pkeys.sort();
+        var total = that.pkeys.length;
+
+        var start = (that.table.current_page - 1) * that.table.page_length + 1;
+        var end = that.table.current_page * that.table.page_length;
+        end = end > total ? total : end;
+
+        var summary = IPA.messages.association.paging;
+        summary = summary.replace('${start}', start);
+        summary = summary.replace('${end}', end);
+        summary = summary.replace('${total}', total);
+        that.table.summary.text(summary);
+
+        that.values = that.pkeys.slice(start-1, end);
+
+        var columns = that.table.columns.values;
+        if (columns.length == 1) { // show pkey only
+            var name = columns[0].name;
+            that.table.empty();
+            for (var i=0; i<that.values.length; i++) {
+                var record = {};
+                record[name] = that.values[i];
+                that.table.add_record(record);
+            }
+            that.table.unselect_all();
+            return;
+        }
+
+        // get and show additional fields
+        that.get_records(
+            function(data, text_status, xhr) {
+                var results = data.result.results;
+                that.table.empty();
+                for (var i=0; i<results.length; i++) {
+                    var record = results[i].result;
+                    that.table.add_record(record);
+                }
+                that.table.unselect_all();
+            },
+            function(xhr, text_status, error_thrown) {
+                that.table.empty();
+                var summary = that.table.summary.empty();
+                summary.append(error_thrown.name+': '+error_thrown.message);
+            }
+        );
     };
 
     that.get_records_command_name = function() {
@@ -518,7 +625,11 @@ IPA.table_facet = function(spec) {
         for (var i=0; i<columns.length; i++) {
             var column = columns[i];
 
-            if (column.link) {
+            var metadata = IPA.get_entity_param(entity.name, column.name);
+            column.primary_key = metadata && metadata.primary_key;
+            column.link = (column.link === undefined ? true : column.link) && column.primary_key;
+
+            if (column.link && column.primary_key) {
                 column.link_handler = function(value) {
                     IPA.nav.show_page(entity.name, 'default', value);
                     return false;
@@ -558,95 +669,6 @@ IPA.table_facet = function(spec) {
             state[that.entity_name+'-page'] = page;
             IPA.nav.push_state(state);
         };
-
-        that.table.load = function(result) {
-
-            that.table.empty();
-
-            for (var i=0; i<result.length; i++) {
-                var record = that.table.get_record(result[i], 0);
-                that.table.add_record(record);
-            }
-
-            that.table.unselect_all();
-        };
-
-        that.table.load_page = function(result) {
-
-            that.load_pkeys(result);
-
-            if (that.pkeys.length) {
-                that.table.total_pages =
-                    Math.ceil(that.pkeys.length / that.table.page_length);
-            } else {
-                that.table.total_pages = 1;
-            }
-
-            delete that.table.current_page;
-
-            var state = {};
-            var page = parseInt(IPA.nav.get_state(that.entity_name+'-page'), 10) || 1;
-            if (page < 1) {
-                state[that.entity_name+'-page'] = 1;
-                IPA.nav.push_state(state);
-                return;
-            } else if (page > that.table.total_pages) {
-                state[that.entity_name+'-page'] = that.table.total_pages;
-                IPA.nav.push_state(state);
-                return;
-            }
-            that.table.current_page = page;
-
-            if (!that.pkeys || !that.pkeys.length) {
-                that.table.empty();
-                that.table.summary.text(IPA.messages.association.no_entries);
-                return;
-            }
-
-            that.pkeys.sort();
-            var total = that.pkeys.length;
-
-            var start = (that.table.current_page - 1) * that.table.page_length + 1;
-            var end = that.table.current_page * that.table.page_length;
-            end = end > total ? total : end;
-
-            var summary = IPA.messages.association.paging;
-            summary = summary.replace('${start}', start);
-            summary = summary.replace('${end}', end);
-            summary = summary.replace('${total}', total);
-            that.table.summary.text(summary);
-
-            that.values = that.pkeys.slice(start-1, end);
-
-            var columns = that.table.columns.values;
-            if (columns.length == 1) { // show pkey only
-                var name = columns[0].name;
-                that.table.empty();
-                for (var i=0; i<that.values.length; i++) {
-                    var entry = {};
-                    entry[name] = that.values[i];
-                    that.table.add_record(entry);
-                }
-                return;
-            }
-
-            // get and show additional fields
-            that.get_records(
-                function(data, text_status, xhr) {
-                    var results = data.result.results;
-                    that.table.empty();
-                    for (var i=0; i<results.length; i++) {
-                        var record = results[i].result;
-                        that.table.add_record(record);
-                    }
-                },
-                function(xhr, text_status, error_thrown) {
-                    that.table.empty();
-                    var summary = that.table.summary.empty();
-                    summary.append(error_thrown.name+': '+error_thrown.message);
-                }
-            );
-        };
     };
 
     init();
@@ -702,14 +724,16 @@ IPA.facet_builder = function(entity) {
 
     that.build_facet = function(spec) {
 
-        var type = spec.type || 'details';
         //do common logic
         spec.entity = entity;
 
         //prepare spec based on type
-        var prepare_method = that.prepare_methods[type];
-        if(prepare_method) {
-            prepare_method.call(that, spec);
+        var type = spec.type;
+        if (type) {
+            var prepare_method = that.prepare_methods[type];
+            if (prepare_method) {
+                prepare_method.call(that, spec);
+            }
         }
 
         //add facet
diff --git a/install/ui/group.js b/install/ui/group.js
index dbeb07ba4913ce03f8bef2c84712e645d7f66d8a..63f835fbe7183d97617bafe802467076fb715725 100644
--- a/install/ui/group.js
+++ b/install/ui/group.js
@@ -58,15 +58,11 @@ IPA.group.entity = function(spec) {
         association_facet({
             name: 'member_user',
             columns:[
-                {
-                    name: 'uid',
-                    primary_key: true,
-                    link: true
-                },
-                {name: 'uidnumber'},
-                {name: 'mail'},
-                {name: 'telephonenumber'},
-                {name: 'title'}
+                'uid',
+                'uidnumber',
+                'mail',
+                'telephonenumber',
+                'title'
             ],
             adder_columns:[
                 {
diff --git a/install/ui/hbac.js b/install/ui/hbac.js
index 902d4f18667a525398a7488f4bda0447e9a5d55a..79fe0f79a5775becf481227ec76c9b55edb1b81c 100644
--- a/install/ui/hbac.js
+++ b/install/ui/hbac.js
@@ -83,12 +83,8 @@ IPA.hbac.service_entity = function(spec) {
             name: 'memberof_hbacsvcgroup',
             associator: IPA.serial_associator,
             columns:[
-                {
-                    name: 'cn',
-                    primary_key: true,
-                    link: true
-                },
-                { name: 'description' }
+                'cn',
+                'description'
             ],
             adder_columns: [
                 {
@@ -148,12 +144,8 @@ IPA.hbac.service_group_entity = function(spec) {
         association_facet({
             name: 'member_hbacsvc',
             columns:[
-                {
-                    name: 'cn',
-                    primary_key: true,
-                    link: true
-                },
-                { name: 'description' }
+                'cn',
+                'description'
             ],
             adder_columns: [
                 {
diff --git a/install/ui/search.js b/install/ui/search.js
index 493edb7f5a6197107e96e7530ca3e48a8df89e2c..221aa5538ffc1ab28b4a200550a527fe462ef598 100644
--- a/install/ui/search.js
+++ b/install/ui/search.js
@@ -48,22 +48,9 @@ IPA.search_facet = function(spec) {
 
         that.managed_entity = IPA.get_entity(that.managed_entity_name);
 
-        var columns = that.columns.values;
-        for (var i=0; i<columns.length; i++) {
-            var column = columns[i];
-
-            var metadata = IPA.get_entity_param(that.managed_entity_name, column.name);
-            column.primary_key = metadata && metadata.primary_key;
-            column.link = column.primary_key;
-        }
-
         that.init_table(that.managed_entity);
     };
 
-    that.create_content = function(container) {
-        that.table.create(container);
-    };
-
     that.create_header = function(container) {
 
         that.facet_create_header(container);
@@ -124,7 +111,6 @@ IPA.search_facet = function(spec) {
         }).appendTo(that.controls);
     };
 
-
     that.show = function() {
         that.facet_show();
 
@@ -178,45 +164,24 @@ IPA.search_facet = function(spec) {
         IPA.nav.push_state(state);
     };
 
-    that.load_pkeys = function(result) {
-        that.pkeys = [];
+    that.get_pkeys = function(data) {
+        var result = data.result.result;
+        var pkey_name = that.managed_entity.metadata.primary_key;
+        var pkeys = [];
         for (var i=0; i<result.length; i++) {
             var record = result[i];
-            var values = record[that.managed_entity.metadata.primary_key];
-            that.pkeys.push(values[0]);
+            var values = record[pkey_name];
+            pkeys.push(values[0]);
         }
-        return that.pkeys;
-    };
-
-    that.on_error = function(xhr, text_status, error_thrown) {
-        that.report_error(error_thrown);
+        return pkeys;
     };
 
     that.get_search_command_name = function() {
-        return that.managed_entity.name + '_find' + (that.pagination ? "_pkeys" : "");
+        return that.managed_entity.name + '_find' + (that.pagination ? '_pkeys' : '');
     };
 
     that.refresh = function() {
 
-        function on_success(data, text_status, xhr) {
-
-            that.load(data.result.result);
-
-            if (data.result.truncated) {
-                var message = IPA.messages.search.truncated;
-                message = message.replace('${counter}', data.result.count);
-                that.table.summary.text(message);
-            } else {
-                that.table.summary.text(data.result.summary);
-            }
-
-            that.table.current_page_input.val(that.table.current_page);
-            that.table.total_pages_span.text(that.table.total_pages);
-
-            that.filter.focus();
-            that.select_changed();
-        }
-
         var filter = [];
         var current_entity = that.managed_entity;
         filter.unshift(IPA.nav.get_state(current_entity.name+'-filter'));
@@ -233,9 +198,7 @@ IPA.search_facet = function(spec) {
             args: filter,
             options: {
                 all: that.search_all
-            },
-            on_success: on_success,
-            on_error: that.on_error
+            }
         });
 
         if (that.pagination) {
@@ -243,6 +206,15 @@ IPA.search_facet = function(spec) {
             command.set_option('sizelimit', 0);
         }
 
+        command.on_success = function(data, text_status, xhr) {
+            that.filter.focus();
+            that.load(data);
+        };
+
+        command.on_error = function(xhr, text_status, error_thrown) {
+            that.report_error(error_thrown);
+        };
+
         command.execute();
     };
 
@@ -260,7 +232,6 @@ IPA.search_facet = function(spec) {
     init();
 
     // methods that should be invoked by subclasses
-    that.search_facet_create_content = that.create_content;
     that.search_facet_refresh = that.refresh;
 
     return that;
diff --git a/install/ui/sudo.js b/install/ui/sudo.js
index 9ad8296b02cad7722bb30c81f292a5137eb0cd5f..5c7e319b15b87a26d550298544155b64c06cee56 100644
--- a/install/ui/sudo.js
+++ b/install/ui/sudo.js
@@ -81,12 +81,8 @@ IPA.sudo.command_entity = function(spec) {
             name: 'memberof_sudocmdgroup',
             associator: IPA.serial_associator,
             columns:[
-                {
-                    name: 'cn',
-                    primary_key: true,
-                    link: true
-                },
-                { name: 'description' }
+                'cn',
+                'description'
             ],
             adder_columns: [
                 {
@@ -146,12 +142,8 @@ IPA.sudo.command_group_entity = function(spec) {
         association_facet({
             name: 'member_sudocmd',
             columns: [
-                {
-                    name: 'sudocmd',
-                    primary_key: true,
-                    link: true
-                },
-                { name: 'description' }
+                'sudocmd',
+                'description'
             ],
             adder_columns: [
                 {
diff --git a/install/ui/test/details_tests.js b/install/ui/test/details_tests.js
index e8f2f7c709b73aa04cd95b9779a1616aba59e5fe..9db147f1b8a3619e52cc6ff1679d0b99113eb37f 100644
--- a/install/ui/test/details_tests.js
+++ b/install/ui/test/details_tests.js
@@ -109,7 +109,9 @@ test("Testing IPA.details_section.create().", function() {
 
 test("Testing details lifecycle: create, load.", function(){
 
-    var result = {};
+    var data = {};
+    data.result = {};
+    data.result.result = {};
 
     IPA.command({
         entity: 'user',
@@ -227,7 +229,7 @@ test("Testing details lifecycle: create, load.", function(){
 
     facet.create(facet_container);
 
-    facet.load(result);
+    facet.load(data);
 
     var contact = $('.details-section[name=contact]', facet_container);
 
diff --git a/install/ui/user.js b/install/ui/user.js
index 9f97c4ae8a4712bf6e6d73114d150c81b9eff441..0158100e747098bd97abd8147ccf12d0278e8fa9 100644
--- a/install/ui/user.js
+++ b/install/ui/user.js
@@ -32,10 +32,7 @@ IPA.user.entity = function(spec) {
     that.init = function() {
         that.entity_init();
 
-        var link = true;
-        if (IPA.nav && IPA.nav.name == 'self-service') {
-            link = false;
-        }
+        var link = IPA.nav.name == 'self-service' ? false : undefined;
 
         that.builder.search_facet({
             columns: [
-- 
1.7.5.1