<html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">On 03/29/2013 02:15 PM, Ana Krivokapic wrote: </div> <blockquote cite="mid:515593DD.3090405@redhat.com" type="cite"> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> <div class="moz-cite-prefix">On 03/26/2013 04:59 PM, Tomas Babej wrote: </div> <blockquote cite="mid:5151C5DE.7090902@redhat.com" type="cite">Hi, The ipa-replica-install script tries to add replica's A and PTR records to the master DNS, if master does manage DNS. However, master need not to manage replica's zone. Properly handle this use case. <a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/3496">https://fedorahosted.org/freeipa/ticket/3496</a> <fieldset class="mimeAttachmentHeader"></fieldset> <pre wrap="">_______________________________________________ Freeipa-devel mailing list <a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a> <a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre> </blockquote> The patch works well and fixes the issue. Just a couple of nitpicks: 1) "However, master need not to manage replica's zone." -- This sentence sounds a little strange to me, but I am not a native speaker so I may be wrong about that. </blockquote> The phrase should be ok. I assume you're worried about "need not" construct, which may sound a bit unusal as opposed to, for example, "does not need to". One could argue that it sounds archaic. However, consider the following chart, which clearly proves the opposite: <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1"> <a href="http://books.google.com/ngrams/chart?content=need%20not%2Cneeds%20not%2Cdoes%20not%20need%20to%2Cdoesn%20%27%20t%20need%20to&corpus=0&smoothing=3&year_start=1800&year_end=2000">http://books.google.com/ngrams/chart?content=need%20not%2Cneeds%20not%2Cdoes%20not%20need%20to%2Cdoesn%20'%20t%20need%20to&corpus=0&smoothing=3&year_start=1800&year_end=2000</a> For more detailed explanation, see: <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1"> <a href="http://english.stackexchange.com/questions/29409/why-use-need-not-instead-of-do-not-need-to">http://english.stackexchange.com/questions/29409/why-use-need-not-instead-of-do-not-need-to</a> <blockquote cite="mid:515593DD.3090405@redhat.com" type="cite"> 2) There are three PEP8 501 errors introduced by the patch, but given the recent discussion on this subject, I think it is really up to you if you want to take the time to fix these. </blockquote> Sure I do. Thanks for the catch. Updated patch attached. <blockquote cite="mid:515593DD.3090405@redhat.com" type="cite"> ACK from the functional perspective. <pre class="moz-signature" cols="72">-- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc.</pre> </blockquote> </body> </html>