<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 05/10/2013 04:57 PM, Petr Spacek
wrote:<br>
</div>
<blockquote cite="mid:518D0AE1.6040609@redhat.com" type="cite">On
6.5.2013 17:40, Tomas Hozza wrote:
<br>
<blockquote type="cite">On 04/08/2013 07:45 PM, Petr Spacek wrote:
<br>
<blockquote type="cite">Generalize
attribute_name<->rdata_type conversions.
<br>
<br>
Attribute names are generated on-the-fly: String "Record" is
appended
<br>
to textual representation of DNS RDATA type.
<br>
<br>
String "Record" is cut down from the attribute name during
<br>
attribute name to rdata type conversion.
<br>
<br>
From now, the plugin doesn't add artificial limitation to
supported
<br>
record types.
<br>
</blockquote>
<br>
ACK.
<br>
<br>
The patch looks good. (I didn't do functional test)
<br>
<br>
Cosmetic issue:
<br>
I think it would be good to dynamically allocate "mod_type" in
LDAPMod
<br>
in every case and include the "mod_type" memory freeing in
<br>
free_ldapmod() function. Now one has to be be careful when it is
<br>
statically or dynamically allocated. Before it was static in
every case.
<br>
</blockquote>
<br>
It is good idea. This version of the patch contains
ldap_mod_create() function which allocates the whole structure
including mod_type of fixed size. All writes to mod_type checks
the array length, so it should not cause any harm.
<br>
<br>
The function modify_soa_record() still uses statically allocated
LDAPMod structure with statically allocated strings for mod_type,
but the LDAPMod structure never leave this function. There are no
calls to ldap_mod_create() and ldap_mod_free(), so I think it is
obvious.
<br>
<br>
Tbabej, please try to dynamically update some A records with
sync_ptr enabled. (And of course the support for some new type,
like TLSA.)
<br>
</blockquote>
For the existing record types, the patch works fine.<br>
<br>
For any new types, a schema change is still required, since record
types are still hardcoded in LDAP schema:<br>
<br>
LDAP error: Object class violation: attribute "tlsarecord" not
allowed<br>
<br>
<blockquote cite="mid:518D0AE1.6040609@redhat.com" type="cite">
<br>
Thank you!
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
Tomas<br>
</body>
</html>