Unsubscribe <div class="gmail_quote">On May 15, 2013 12:01 PM, <<a href="mailto:freeipa-devel-request@redhat.com">freeipa-devel-request@redhat.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Send Freeipa-devel mailing list submissions to <a href="mailto:freeipa-devel@redhat.com">freeipa-devel@redhat.com</a> To subscribe or unsubscribe via the World Wide Web, visit <a href="https://www.redhat.com/mailman/listinfo/freeipa-devel" target="_blank">https://www.redhat.com/mailman/listinfo/freeipa-devel</a> or, via email, send a message with subject or body 'help' to <a href="mailto:freeipa-devel-request@redhat.com">freeipa-devel-request@redhat.com</a> You can reach the person managing the list at <a href="mailto:freeipa-devel-owner@redhat.com">freeipa-devel-owner@redhat.com</a> When replying, please edit your Subject line so it is more specific than "Re: Contents of Freeipa-devel digest..." Today's Topics: 1. Re: [PATCH] 0026 Do not display success message on failure in web UI (Ana Krivokapic) ---------------------------------------------------------------------- Message: 1 Date: Wed, 15 May 2013 17:43:28 +0200 From: Ana Krivokapic <<a href="mailto:akrivoka@redhat.com">akrivoka@redhat.com</a>> To: Petr Vobornik <<a href="mailto:pvoborni@redhat.com">pvoborni@redhat.com</a>> Cc: freeipa-devel <<a href="mailto:freeipa-devel@redhat.com">freeipa-devel@redhat.com</a>> Subject: Re: [Freeipa-devel] [PATCH] 0026 Do not display success message on failure in web UI Message-ID: <<a href="mailto:5193AD20.1050001@redhat.com">5193AD20.1050001@redhat.com</a>> Content-Type: text/plain; charset="iso-8859-1" On 05/13/2013 04:51 PM, Petr Vobornik wrote: > On 05/07/2013 05:16 PM, Ana Krivokapic wrote: >> <a href="https://fedorahosted.org/freeipa/ticket/3591" target="_blank">https://fedorahosted.org/freeipa/ticket/3591</a> >> > > 1) The change from on_success to on_error is causing problems when > some command in a batch doesn't fail. Ie.: disable multiple users on > user search facet. Disabling already disabled user causes an error. > The dialog is shown but the page is not refreshed so the newly > disabled records are still displayed as enabled. We might even call > this case a success. > > IMO we shouldn't change the method because the batch itself succeeded. > The problem should be fixed on caller side (users of batch command). > > 2) Also `ajax` context should be left there instead of `this`, > otherwise it would get the context of on_ok handler: > > 3) (not an actual issue) Some of my old code doesn't contain space > between for/if and opening curly bracet, opposite to the rest of the > Web UI. Spaces should be added when touching these parts of code. Since the problem occurs in the case when the batch succeeds, but some commands from the batch fail, it should be enough to modify the message that is displayed. I modified it so it shows exactly how many items from the batch succeeded. Updated patch is attached. -- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc. -------------- next part -------------- A non-text attachment was scrubbed... Name: freeipa-akrivoka-0026-02-Do-not-display-success-message-on-failure-in-web-UI.patch Type: text/x-patch Size: 2849 bytes Desc: not available URL: <<a href="https://www.redhat.com/archives/freeipa-devel/attachments/20130515/67c3a9c8/attachment.bin" target="_blank">https://www.redhat.com/archives/freeipa-devel/attachments/20130515/67c3a9c8/attachment.bin</a>> ------------------------------ _______________________________________________ Freeipa-devel mailing list <a href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a> <a href="https://www.redhat.com/mailman/listinfo/freeipa-devel" target="_blank">https://www.redhat.com/mailman/listinfo/freeipa-devel</a> End of Freeipa-devel Digest, Vol 72, Issue 51 ********************************************* </blockquote></div>